Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: media/remoting/remoting_renderer_controller.cc

Issue 2566223005: Media Remoting: Update remoting interstitial when status changes. (Closed)
Patch Set: Rebased only. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/remoting/remoting_renderer_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/remoting/remoting_renderer_controller.cc
diff --git a/media/remoting/remoting_renderer_controller.cc b/media/remoting/remoting_renderer_controller.cc
index c58c17a5b3678cfab28ca256cd09a9e49c36f9a8..0464d9ede23253866446a34402a2a5320acc5413 100644
--- a/media/remoting/remoting_renderer_controller.cc
+++ b/media/remoting/remoting_renderer_controller.cc
@@ -7,10 +7,21 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/threading/thread_checker.h"
+#include "media/base/video_util.h"
#include "media/remoting/remoting_cdm_context.h"
namespace media {
+namespace {
+
+gfx::Size GetRotatedVideoSize(VideoRotation rotation, gfx::Size natural_size) {
+ if (rotation == VIDEO_ROTATION_90 || rotation == VIDEO_ROTATION_270)
+ return gfx::Size(natural_size.height(), natural_size.width());
+ return natural_size;
+}
+
+} // namespace
+
RemotingRendererController::RemotingRendererController(
scoped_refptr<RemotingSourceImpl> remoting_source)
: remoting_source_(remoting_source), weak_factory_(this) {
@@ -46,6 +57,7 @@ void RemotingRendererController::OnSessionStateChanged() {
if (!sink_available_changed_cb_.is_null())
sink_available_changed_cb_.Run(IsRemoteSinkAvailable());
+ UpdateInterstitial();
UpdateAndMaybeSwitch();
}
@@ -146,17 +158,22 @@ void RemotingRendererController::OnMetadataChanged(
const PipelineMetadata& metadata) {
DCHECK(thread_checker_.CalledOnValidThread());
+ const gfx::Size old_size = pipeline_metadata_.natural_size;
pipeline_metadata_ = metadata;
is_encrypted_ = false;
if (has_video()) {
- video_decoder_config_ = metadata.video_decoder_config;
- is_encrypted_ |= video_decoder_config_.is_encrypted();
+ is_encrypted_ |= metadata.video_decoder_config.is_encrypted();
+ pipeline_metadata_.natural_size = GetRotatedVideoSize(
+ pipeline_metadata_.video_rotation, pipeline_metadata_.natural_size);
}
if (has_audio()) {
- audio_decoder_config_ = metadata.audio_decoder_config;
- is_encrypted_ |= audio_decoder_config_.is_encrypted();
+ is_encrypted_ |= metadata.audio_decoder_config.is_encrypted();
}
+
+ if (pipeline_metadata_.natural_size != old_size)
+ UpdateInterstitial();
+
UpdateAndMaybeSwitch();
}
@@ -164,13 +181,13 @@ bool RemotingRendererController::IsVideoCodecSupported() {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(has_video());
- switch (video_decoder_config_.codec()) {
+ switch (pipeline_metadata_.video_decoder_config.codec()) {
case VideoCodec::kCodecH264:
case VideoCodec::kCodecVP8:
return true;
default:
VLOG(2) << "Remoting does not support video codec: "
- << video_decoder_config_.codec();
+ << pipeline_metadata_.video_decoder_config.codec();
return false;
}
}
@@ -179,7 +196,7 @@ bool RemotingRendererController::IsAudioCodecSupported() {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(has_audio());
- switch (audio_decoder_config_.codec()) {
+ switch (pipeline_metadata_.audio_decoder_config.codec()) {
case AudioCodec::kCodecAAC:
case AudioCodec::kCodecMP3:
case AudioCodec::kCodecPCM:
@@ -199,7 +216,7 @@ bool RemotingRendererController::IsAudioCodecSupported() {
return true;
default:
VLOG(2) << "Remoting does not support audio codec: "
- << audio_decoder_config_.codec();
+ << pipeline_metadata_.audio_decoder_config.codec();
return false;
}
}
@@ -309,4 +326,36 @@ void RemotingRendererController::UpdateAndMaybeSwitch() {
}
}
+void RemotingRendererController::SetShowInterstitialCallback(
+ const ShowInterstitialCallback& cb) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ show_interstitial_cb_ = cb;
+ UpdateInterstitial();
+}
+
+void RemotingRendererController::UpdateInterstitial() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ if (show_interstitial_cb_.is_null() ||
+ pipeline_metadata_.natural_size.IsEmpty())
+ return;
+
+ RemotingInterstitialType type = RemotingInterstitialType::BETWEEN_SESSIONS;
+ switch (remoting_source_->state()) {
+ case SESSION_STARTED:
+ type = RemotingInterstitialType::IN_SESSION;
+ break;
+ case SESSION_PERMANENTLY_STOPPED:
+ type = RemotingInterstitialType::ENCRYPTED_MEDIA_FATAL_ERROR;
+ break;
+ case SESSION_UNAVAILABLE:
+ case SESSION_CAN_START:
+ case SESSION_STARTING:
+ case SESSION_STOPPING:
+ break;
+ }
+
+ // TODO(xjz): Download poster image when available.
+ show_interstitial_cb_.Run(SkBitmap(), pipeline_metadata_.natural_size, type);
+}
+
} // namespace media
« no previous file with comments | « media/remoting/remoting_renderer_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698