Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 25662002: Revert 226305 "Fix code style and gyp files in cast to build cas..." (Closed)

Created:
7 years, 2 months ago by piman
Modified:
7 years, 2 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226305 "Fix code style and gyp files in cast to build cas..." Seems to have broken win and mac: http://build.chromium.org/p/chromium/builders/Win/builds/17341 http://build.chromium.org/p/chromium/builders/Mac/builds/22281 > Fix code style and gyp files in cast to build cast_unittest > > *.gypi should not be used for dependency directly. Renaming those files > to *.gyp. Also style fixes to make compilers happy. > > This change is reland of r226264. > > TBR=acolwell > > Review URL: https://codereview.chromium.org/25544003 TBR=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -392 lines) Patch
M trunk/src/media/cast/audio_receiver/audio_decoder.h View 3 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.h View 3 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/media/cast/cast_config.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_config.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_receiver.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_receiver.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/media/cast/cast_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast_sender_impl.h View 1 chunk +7 lines, -2 lines 0 comments Download
M trunk/src/media/cast/cast_sender_impl.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M trunk/src/media/cast/cast_thread.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_thread.cc View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/congestion_control/congestion_control.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/congestion_control/congestion_control.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/media/cast/framer/cast_message_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/framer/frame_buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/framer/framer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/pacing/mock_paced_packet_sender.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/pacing/mock_paced_packet_sender.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/pacing/mock_packet_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/media/cast/pacing/mock_packet_sender.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/pacing/paced_sender.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/pacing/paced_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtcp/mock_rtcp_receiver_feedback.h View 2 chunks +0 lines, -6 lines 0 comments Download
D trunk/src/media/cast/rtcp/mock_rtcp_receiver_feedback.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M trunk/src/media/cast/rtcp/mock_rtcp_sender_feedback.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/rtcp/mock_rtcp_sender_feedback.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_common/mock_rtp_payload_feedback.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/rtp_common/mock_rtp_payload_feedback.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/receiver_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
A + trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_receiver.gyp View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/media/cast/rtp_sender/packet_storage/packet_storage.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
A + trunk/src/media/cast/rtp_sender/packet_storage/packet_storage.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
A + trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.h View 1 chunk +9 lines, -1 line 0 comments Download
D trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtp_sender/rtp_sender.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder.h View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver.cc View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/media/cast/video_sender/codecs/vp8/vp8_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/mock_video_encoder_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/media/cast/video_sender/mock_video_encoder_controller.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/video_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
7 years, 2 months ago (2013-10-02 01:47:27 UTC) #1
piman
Committed patchset #1 manually as r226381.
7 years, 2 months ago (2013-10-02 01:47:46 UTC) #2
Alpha Left Google
This revert was not necessary. The change was taken out of build/all.gyp so it won't ...
7 years, 2 months ago (2013-10-02 04:29:21 UTC) #3
Alpha Left Google
You just needed to reopen the tree and it will recycle.
7 years, 2 months ago (2013-10-02 04:30:51 UTC) #4
piman
Too late... On Tue, Oct 1, 2013 at 9:30 PM, <hclam@chromium.org> wrote: > You just ...
7 years, 2 months ago (2013-10-02 04:35:30 UTC) #5
Alpha Left Google
No worries. I'll land it again tomorrow. :) 2013/10/1 Antoine Labour <piman@chromium.org> > Too late... ...
7 years, 2 months ago (2013-10-02 04:36:06 UTC) #6
piman
7 years, 2 months ago (2013-10-02 04:42:05 UTC) #7
On Tue, Oct 1, 2013 at 9:36 PM, Alpha Lam <hclam@chromium.org> wrote:

> No worries. I'll land it again tomorrow. :)
>

Sorry about that, it wasn't clear it was already fixed, the status message
was clobbered. I waited 10 minutes on the channel for an answer... I'll go
through IRC logs next time.

Antoine


>
>
> 2013/10/1 Antoine Labour <piman@chromium.org>
>
>> Too late...
>>
>>
>> On Tue, Oct 1, 2013 at 9:30 PM, <hclam@chromium.org> wrote:
>>
>>> You just needed to reopen the tree and it will recycle.
>>>
>>>
https://codereview.chromium.**org/25662002/<https://codereview.chromium.org/2...
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698