chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc - Issue 2566153007: Implement PrintBrowser functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

Issue 2566153007: Implement PrintBrowser functionality. (Closed)

Patch Set: Fix git weirdness Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

diff --git a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

index 0796532247d33d93a1debea4c6d0488fc046c77e..a2605083c28f12b24a6fe366eb841e75a01e8939 100644

--- a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

+++ b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

@@ -54,7 +54,6 @@ blink::WebElement ChromePrintWebViewHelperDelegate::GetPdfElement(

if (!plugin_element.isNull()) {

skau 2016/12/16 18:32:50 Why is there a situation where this is null now?

return plugin_element;

}

- NOTREACHED();

}

#endif // BUILDFLAG(ENABLE_EXTENSIONS)

return blink::WebElement();