Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2566123002: Last visit dates of bookmarks - fix browsing data removal on desktop (Closed)
Patch Set: Adding a unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 07381b0d55ecb9b1bda00535342fd0cb1ad37a22..7b2f82cb71831db80b9fe8788cc226aedced723f 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -48,6 +48,10 @@ class BrowsingDataRemoverFactory;
class Profile;
class WebappRegistry;
+namespace bookmarks {
+class BookmarkModel;
+}
+
namespace chrome_browser_net {
class Predictor;
}
@@ -287,6 +291,11 @@ class BrowsingDataRemover : public KeyedService
scoped_refptr<BrowsingDataFlashLSOHelper> flash_lso_helper);
#endif
+ void OverrideBookmarkModelForTesting(
+ bookmarks::BookmarkModel* bookmark_model) {
+ bookmark_model_for_testing_ = bookmark_model;
+ }
+
// Parameters of the last call are exposed to be used by tests. Removal and
// origin type masks equal to -1 mean that no removal has ever been executed.
// TODO(msramek): If other consumers than tests are interested in this,
@@ -560,6 +569,7 @@ class BrowsingDataRemover : public KeyedService
// We do not own this.
content::StoragePartition* storage_partition_for_testing_ = nullptr;
+ bookmarks::BookmarkModel* bookmark_model_for_testing_ = nullptr;
#if BUILDFLAG(ANDROID_JAVA_UI)
// WebappRegistry makes calls across the JNI. In unit tests, the Java side is

Powered by Google App Engine
This is Rietveld 408576698