Last visit dates of bookmarks - fix browsing data removal on desktop

components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 132 matching lines @@
           callback,
           Status(StatusCode::PERMANENT_ERROR,
                  "BookmarkSuggestionsProvider has no |Fetch| functionality!"),
           base::Passed(std::vector<ContentSuggestion>())));
 }
 
 void BookmarkSuggestionsProvider::ClearHistory(
     base::Time begin,
     base::Time end,
     const base::Callback<bool(const GURL& url)>& filter) {
-  // TODO(vitaliii): Do not remove all dates, but only the ones matched by the
-  // time range and the filter.
-  RemoveAllLastVisitDates(bookmark_model_);
+  // The last visit dates are not "owned" by the bookmark suggestion provider so
+  // it is cleared directly from browsing_data_remover.cc.
   ClearDismissedSuggestionsForDebugging(provided_category_);
   FetchBookmarks();
   // Temporarily enter an "explicitly disabled" state, so that any open UIs
   // will clear the suggestions too.
   if (category_status_ != CategoryStatus::CATEGORY_EXPLICITLY_DISABLED) {
     CategoryStatus old_category_status = category_status_;
     NotifyStatusChanged(CategoryStatus::CATEGORY_EXPLICITLY_DISABLED);
     NotifyStatusChanged(old_category_status);
   }
 }
@@ skipping 159 matching lines @@
 void BookmarkSuggestionsProvider::NotifyStatusChanged(
     CategoryStatus new_status) {
   if (category_status_ == new_status) {
     return;
   }
   category_status_ = new_status;
   observer()->OnCategoryStatusChanged(this, provided_category_, new_status);
 }
 
 }  // namespace ntp_snippets