Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2566013002: Implement 'analysis.getErrors' for the new driver. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -51 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +27 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_after_analysis_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/source/error_processor.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-11 20:45:32 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-11 23:18:01 UTC) #2
scheglov
4 years ago (2016-12-11 23:27:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0728e4ee7012dc23d42d0317154172f7d730c671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698