Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2566003002: When a file is removed from the driver, reschedule full analysis. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When a file is removed from the driver, reschedule full analysis. Removing files happens rarely, so it should be OK to keep it simple and just reset the file state and let analysis to happen from scratch. It look in profiler that the most expensive operation is recomputing content hash (16%) and unlinked bundle key hash (14%). Reading content itself is somewhat expensive (11%) on SSD. Might be higher on NFS. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/662ba0908f1064e57d77468249b36e97146fc3e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-11 19:12:12 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-11 19:21:44 UTC) #2
scheglov
4 years ago (2016-12-11 19:38:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
662ba0908f1064e57d77468249b36e97146fc3e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698