Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 25660014: Add alaw codec for .wav files. (Closed)

Created:
7 years, 2 months ago by ilja
Modified:
7 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Add alaw codec for .wav files. Also add corresponding test. (The test media is already there.) BUG=chromium:217772 TEST=Played 2 test files on Pixel. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233101

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/browser/media/media_browsertest.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M media/base/audio_decoder_config.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
DaleCurtis
This can be landed now. lgtm
7 years, 1 month ago (2013-11-05 00:34:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/25660014/1
7 years, 1 month ago (2013-11-05 01:05:19 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 01:48:34 UTC) #3
DaleCurtis
https://codereview.chromium.org/25660014/diff/1/content/browser/media/media_browsertest.cc File content/browser/media/media_browsertest.cc (right): https://codereview.chromium.org/25660014/diff/1/content/browser/media/media_browsertest.cc#newcode171 content/browser/media/media_browsertest.cc:171: IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearWavAlaw) { Just realized these alaw and mulaw ...
7 years, 1 month ago (2013-11-05 01:50:18 UTC) #4
ilja
https://codereview.chromium.org/25660014/diff/1/content/browser/media/media_browsertest.cc File content/browser/media/media_browsertest.cc (right): https://codereview.chromium.org/25660014/diff/1/content/browser/media/media_browsertest.cc#newcode171 content/browser/media/media_browsertest.cc:171: IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearWavAlaw) { On 2013/11/05 01:50:18, DaleCurtis wrote: > ...
7 years, 1 month ago (2013-11-05 02:26:52 UTC) #5
DaleCurtis
lgtm
7 years, 1 month ago (2013-11-05 02:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/25660014/296001
7 years, 1 month ago (2013-11-05 02:36:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/25660014/296001
7 years, 1 month ago (2013-11-05 03:00:09 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184801
7 years, 1 month ago (2013-11-05 06:46:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/25660014/296001
7 years, 1 month ago (2013-11-05 19:21:51 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 22:14:39 UTC) #11
Message was sent while issue was closed.
Change committed as 233101

Powered by Google App Engine
This is Rietveld 408576698