Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 256593011: Remove invalid HCheckValue case in check elimination. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove invalid HCheckValue case in check elimination. Also eliminate a useless copy of the map set in case of HCheckMaps. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M src/hydrogen-check-elimination.cc View 3 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-04-28 10:54:32 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-04-28 12:02:55 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-04-29 04:59:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698