Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Unified Diff: Source/modules/gamepad/NavigatorGamepad.h

Issue 256593010: Gracefully support Navigator Gamepad methods in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have document supplements keep a reference to their document Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/gamepad/NavigatorGamepad.h
diff --git a/Source/modules/gamepad/NavigatorGamepad.h b/Source/modules/gamepad/NavigatorGamepad.h
index d5015c858b162120e7b228d221f1c9ce19c70c2c..15f9cf7a3bb73862130ae8ea347098210f7f2f9c 100644
--- a/Source/modules/gamepad/NavigatorGamepad.h
+++ b/Source/modules/gamepad/NavigatorGamepad.h
@@ -62,25 +62,26 @@ public:
void didConnectOrDisconnectGamepad(unsigned index, const blink::WebGamepad&, bool connected);
private:
- explicit NavigatorGamepad(Document&);
+ explicit NavigatorGamepad(LocalFrame*);
static const char* supplementName();
// DOMWindowProperty
- virtual void willDestroyGlobalObjectInFrame() OVERRIDE FINAL;
- virtual void willDetachGlobalObjectFromFrame() OVERRIDE FINAL;
+ virtual void willDestroyGlobalObjectInFrame() OVERRIDE;
+ virtual void willDetachGlobalObjectFromFrame() OVERRIDE;
// DeviceSensorEventController
- virtual void registerWithDispatcher() OVERRIDE FINAL;
- virtual void unregisterWithDispatcher() OVERRIDE FINAL;
- virtual bool hasLastData() OVERRIDE FINAL;
- virtual PassRefPtrWillBeRawPtr<Event> getLastEvent() OVERRIDE FINAL;
- virtual bool isNullEvent(Event*) OVERRIDE FINAL;
+ virtual void registerWithDispatcher() OVERRIDE;
+ virtual void unregisterWithDispatcher() OVERRIDE;
+ virtual bool hasLastData() OVERRIDE;
+ virtual PassRefPtrWillBeRawPtr<Event> getLastEvent() OVERRIDE;
+ virtual bool isNullEvent(Event*) OVERRIDE;
+ virtual Document* document() OVERRIDE;
// DOMWindowLifecycleObserver
- virtual void didAddEventListener(DOMWindow*, const AtomicString&) OVERRIDE FINAL;
- virtual void didRemoveEventListener(DOMWindow*, const AtomicString&) OVERRIDE FINAL;
- virtual void didRemoveAllEventListeners(DOMWindow*) OVERRIDE FINAL;
+ virtual void didAddEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
+ virtual void didRemoveEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
+ virtual void didRemoveAllEventListeners(DOMWindow*) OVERRIDE;
PersistentWillBeMember<GamepadList> m_gamepads;
PersistentWillBeMember<WebKitGamepadList> m_webkitGamepads;
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | Source/modules/gamepad/NavigatorGamepad.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698