Source/modules/device_orientation/DeviceMotionController.cpp - Issue 256593010: Gracefully support Navigator Gamepad methods in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceMotionController.cpp

Issue 256593010: Gracefully support Navigator Gamepad methods in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have document supplements keep a reference to their document Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceMotionController.h ('k') | Source/modules/device_orientation/DeviceOrientationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceMotionController.cpp

diff --git a/Source/modules/device_orientation/DeviceMotionController.cpp b/Source/modules/device_orientation/DeviceMotionController.cpp

index d36e1983f4f4121ac381586f821816928f26cf82..78409747ccb1beac7e73be0fea2f9c83446e0138 100644

--- a/Source/modules/device_orientation/DeviceMotionController.cpp

+++ b/Source/modules/device_orientation/DeviceMotionController.cpp

@@ -37,8 +37,9 @@

namespace WebCore {

DeviceMotionController::DeviceMotionController(Document& document)

- : DeviceSensorEventController(document)

+ : DeviceSensorEventController(document.page())

, DOMWindowLifecycleObserver(document.domWindow())

+ , m_document(document)

{

}

@@ -93,6 +94,11 @@ bool DeviceMotionController::isNullEvent(Event* event)

return !motionEvent->deviceMotionData()->canProvideEventData();

}

+Document* DeviceMotionController::document()

+ return &m_document;

void DeviceMotionController::didAddEventListener(DOMWindow* window, const AtomicString& eventType)

{

if (eventType != EventTypeNames::devicemotion)