Source/core/frame/DeviceSensorEventController.h - Issue 256593010: Gracefully support Navigator Gamepad methods in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DeviceSensorEventController.h

Issue 256593010: Gracefully support Navigator Gamepad methods in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have document supplements keep a reference to their document Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/gamepad/resources/gamepad-detached-no-crash-new-window.html ('k') | Source/core/frame/DeviceSensorEventController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/DeviceSensorEventController.h

diff --git a/Source/core/frame/DeviceSensorEventController.h b/Source/core/frame/DeviceSensorEventController.h

index 085f1e2a1c71b79e0d7aa6e248347f329eec47e9..b3ed0e4001c7338632ac8643bdd632590b3d5c71 100644

--- a/Source/core/frame/DeviceSensorEventController.h

+++ b/Source/core/frame/DeviceSensorEventController.h

@@ -41,7 +41,7 @@ public:

void stopUpdating();

protected:

- explicit DeviceSensorEventController(Document&);

+ explicit DeviceSensorEventController(Page*);

virtual ~DeviceSensorEventController();

void dispatchDeviceEvent(const PassRefPtrWillBeRawPtr<Event>);

@@ -51,6 +51,7 @@ protected:

virtual void registerWithDispatcher() = 0;

virtual void unregisterWithDispatcher() = 0;

virtual bool isNullEvent(Event*) = 0;

+ virtual Document* document() = 0;

bool m_hasEventListener;

@@ -60,7 +61,6 @@ private:

void fireDeviceEvent(Timer<DeviceSensorEventController>*);

- Document& m_document;

bool m_isActive;

bool m_needsCheckingNullEvents;

Timer<DeviceSensorEventController> m_timer;