Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 256593009: Create a baseline RenderBlock::lineHeight() performance (Closed)

Created:
6 years, 8 months ago by rhogan
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Create a baseline RenderBlock::lineHeight() performance This test calls RenderBlock::lineHeight() ~425,000 times on each run. I hope to remove the caching of RenderStyle::computedLineHeight() by |m_lineHeight| in RenderBlock so this will baseline will ensure it doesn't regress performance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175356

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A PerformanceTests/Layout/line-layout-line-height.html View 1 chunk +35 lines, -0 lines 4 comments Download

Messages

Total messages: 10 (0 generated)
rhogan
The follow up to this will be : https://codereview.chromium.org/260073005/. Look there for more context on ...
6 years, 7 months ago (2014-04-28 20:09:21 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/256593009/diff/1/PerformanceTests/Layout/line-layout-line-height.html File PerformanceTests/Layout/line-layout-line-height.html (right): https://codereview.chromium.org/256593009/diff/1/PerformanceTests/Layout/line-layout-line-height.html#newcode4 PerformanceTests/Layout/line-layout-line-height.html:4: <title>Line height calculation performance test</title> Can't we dump ...
6 years, 7 months ago (2014-04-28 20:11:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/256593009/1
6 years, 7 months ago (2014-04-28 20:11:55 UTC) #3
Julien - ping for review
Oups, click epic failure. I didn't really mean to LGTM as this is more Levi's ...
6 years, 7 months ago (2014-04-28 20:12:53 UTC) #4
Julien - ping for review
The CQ bit was unchecked by jchaffraix@chromium.org
6 years, 7 months ago (2014-04-28 20:12:59 UTC) #5
leviw_travelin_and_unemployed
LGTM with Julien's nits addressed.
6 years, 7 months ago (2014-04-28 20:42:18 UTC) #6
leviw_travelin_and_unemployed
For the record, regardless of what you found in your checks, I support more blink ...
6 years, 7 months ago (2014-05-01 08:11:35 UTC) #7
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 6 months ago (2014-06-03 10:30:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/256593009/1
6 years, 6 months ago (2014-06-03 10:30:57 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 11:30:13 UTC) #10
Message was sent while issue was closed.
Change committed as 175356

Powered by Google App Engine
This is Rietveld 408576698