Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256593005: Whitelist FIDO U2F extension to usb,hid (Closed)

Created:
6 years, 8 months ago by Arnar Birgisson
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Whitelist FIDO U2F extension to usb,hid TBR=kalman BUG=361199 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 2 chunks +39 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Arnar Birgisson
Hi miket, Could you please review these whitelist changes? See crbug.com/361199 for details. Thanks!
6 years, 8 months ago (2014-04-25 08:00:04 UTC) #1
miket_OOO
Removing self, adding Ken
6 years, 8 months ago (2014-04-25 16:47:22 UTC) #2
Ken Rockot(use gerrit already)
On 2014/04/25 16:47:22, miket wrote: > Removing self, adding Ken This LGTM. I've TBR'd an ...
6 years, 8 months ago (2014-04-25 16:48:59 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 16:49:06 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 16:49:08 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 17:07:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/256593005/1
6 years, 8 months ago (2014-04-25 22:15:15 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 10:30:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 266360

Powered by Google App Engine
This is Rietveld 408576698