Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: ui/events/gesture_event_details.cc

Issue 256593003: Also pass unclamped delta and velocity values to GestureEventDetails. (DEPRECATED) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_event_details.cc
diff --git a/ui/events/gesture_event_details.cc b/ui/events/gesture_event_details.cc
index 389a9249625b7635636b76aee362a3a4b451b399..49886217d64d0eb715e49f8d3621bd902a8b16a9 100644
--- a/ui/events/gesture_event_details.cc
+++ b/ui/events/gesture_event_details.cc
@@ -19,20 +19,6 @@ GestureEventDetails::GestureEventDetails(ui::EventType type,
data.scroll_begin.y_hint = delta_y;
break;
- case ui::ET_GESTURE_SCROLL_UPDATE:
- data.scroll_update.x = delta_x;
- data.scroll_update.y = delta_y;
- data.scroll_update.x_ordinal = delta_x;
- data.scroll_update.y_ordinal = delta_y;
- break;
-
- case ui::ET_SCROLL_FLING_START:
sadrul 2014/04/25 12:13:14 Do NOTREACHED() for SCROLL_UPDATE and SCROLL_FLING
- data.fling_velocity.x = delta_x;
- data.fling_velocity.y = delta_y;
- data.fling_velocity.x_ordinal = delta_x;
- data.fling_velocity.y_ordinal = delta_y;
- break;
-
case ui::ET_GESTURE_TWO_FINGER_TAP:
data.first_finger_enclosing_rectangle.width = delta_x;
data.first_finger_enclosing_rectangle.height = delta_y;
@@ -58,10 +44,9 @@ GestureEventDetails::GestureEventDetails(ui::EventType type,
break;
default:
- if (delta_x != 0.f || delta_y != 0.f) {
- DLOG(WARNING) << "A gesture event (" << type << ") had unknown data: ("
- << delta_x << "," << delta_y;
- }
+ DCHECK(!delta_x && !delta_y) "A gesture event ("
+ << type << ") had unknown data: (" << delta_x << "," << delta_y
+ << ")";
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698