Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 256593003: Also pass unclamped delta and velocity values to GestureEventDetails. (DEPRECATED) (Closed)

Created:
6 years, 8 months ago by tdresser
Modified:
6 years, 8 months ago
Reviewers:
jdduke (slow), sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Visibility:
Public.

Description

NOTE: this is superseded by https://codereview.chromium.org/258803002. Also pass unclamped delta and velocity values to GestureEventDetails. BUG=332418 TEST=GestureProviderTest.FlingEventSequence, GestureProviderTest.FlingAndCancelLongPress GestureProviderTest.ScrollUpdateValues

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -28 lines) Patch
M ui/events/gesture_detection/gesture_provider.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 6 chunks +22 lines, -6 lines 1 comment Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 3 chunks +16 lines, -3 lines 2 comments Download
M ui/events/gesture_event_details.cc View 2 chunks +3 lines, -18 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
tdresser
jdduke@, can you take a look at ui/events/gesture_detection/*? sadrul@, can you take a look at ...
6 years, 8 months ago (2014-04-24 19:48:59 UTC) #1
jdduke (slow)
A few nits, and I would love to know how the term "ordinal" became associated ...
6 years, 8 months ago (2014-04-24 19:58:53 UTC) #2
sadrul
On 2014/04/24 19:58:53, jdduke wrote: > A few nits, and I would love to know ...
6 years, 8 months ago (2014-04-24 20:00:34 UTC) #3
sadrul
6 years, 8 months ago (2014-04-25 12:13:13 UTC) #4
https://codereview.chromium.org/256593003/diff/1/ui/events/gesture_event_deta...
File ui/events/gesture_event_details.cc (left):

https://codereview.chromium.org/256593003/diff/1/ui/events/gesture_event_deta...
ui/events/gesture_event_details.cc:29: case ui::ET_SCROLL_FLING_START:
Do NOTREACHED() for SCROLL_UPDATE and SCROLL_FLING_START in here instead? (for
readability)

Powered by Google App Engine
This is Rietveld 408576698