Issue 25659002: Revert 226347 "Fixes use after free caused by delete in RootWind..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25659002: Revert 226347 "Fixes use after free caused by delete in RootWind..." (Closed)

Created:
7 years, 2 months ago by dcheng

Modified:
7 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 226347 "Fixes use after free caused by delete in RootWind..." > Fixes use after free caused by delete in RootWindowController > > RootWindowController::CloseChildWindows() was explicitly deleting > windows. It should only do that for windows that are owned by the > parent, otherwise the window should be removed. > > BUG=297028 > TEST=covered by test now. > R=oshima@chromium.org > > Review URL: https://codereview.chromium.org/25374002 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226377

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -77 lines)			Patch
M	trunk/src/ash/root_window_controller.cc	View	3 chunks	+3 lines, -12 lines	0 comments	Download
M	trunk/src/ash/root_window_controller_unittest.cc	View	2 chunks	+0 lines, -64 lines	0 comments	Download
M	trunk/src/ash/wm/frame_painter.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/ui/aura/window.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r226377.