components/translate/core/browser/BUILD.gn - Issue 2565873002: [translate] Add translate ranker model loader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/BUILD.gn

Issue 2565873002: [translate] Add translate ranker model loader. (Closed)

Patch Set: comments from sdefresne Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_ranker_metrics_provider.cc ('k') | components/translate/core/browser/mock_translate_ranker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/BUILD.gn

diff --git a/components/translate/core/browser/BUILD.gn b/components/translate/core/browser/BUILD.gn

index fc31a04facd4c73ac78743f13b9612baba5e77d9..8b359e1fdbb55057cfba73be0f9f34b726b54db9 100644

--- a/components/translate/core/browser/BUILD.gn

+++ b/components/translate/core/browser/BUILD.gn

@@ -11,6 +11,10 @@ static_library("browser") {

"language_state.cc",

"language_state.h",

"page_translated_details.h",

+ "ranker_model.cc",

+ "ranker_model.h",

+ "ranker_model_loader.cc",

+ "ranker_model_loader.h",

"translate_accept_languages.cc",

"translate_accept_languages.h",

"translate_browser_metrics.cc",

@@ -30,10 +34,9 @@ static_library("browser") {

"translate_manager.h",

"translate_prefs.cc",

"translate_prefs.h",

- "translate_ranker.cc",

"translate_ranker.h",

- "translate_ranker_metrics_provider.cc",

- "translate_ranker_metrics_provider.h",

+ "translate_ranker_impl.cc",

+ "translate_ranker_impl.h",

"translate_script.cc",

"translate_script.h",

"translate_step.h",

@@ -90,11 +93,14 @@ source_set("unit_tests") {

"language_state_unittest.cc",

"mock_translate_driver.cc",

"mock_translate_driver.h",

+ "mock_translate_ranker.cc",

+ "mock_translate_ranker.h",

+ "ranker_model_loader_unittest.cc",

"translate_browser_metrics_unittest.cc",

"translate_language_list_unittest.cc",

"translate_manager_unittest.cc",

"translate_prefs_unittest.cc",

- "translate_ranker_unittest.cc",

+ "translate_ranker_impl_unittest.cc",

"translate_script_unittest.cc",

"translate_ui_delegate_unittest.cc",

]