components/translate/core/browser/proto/translate_ranker_model.proto - Issue 2565873002: [translate] Add translate ranker model loader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/proto/translate_ranker_model.proto

Issue 2565873002: [translate] Add translate ranker model loader. (Closed)

Patch Set: for asan testing only - DO NOT COMMIT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/core/browser/mock_translate_ranker.cc ('K') | « components/translate/core/browser/proto/ranker_model.proto ('k') | components/translate/core/browser/ranker_model_loader.h » ('j') | components/translate/core/browser/ranker_model_loader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/proto/translate_ranker_model.proto

diff --git a/components/translate/core/browser/proto/translate_ranker_model.proto b/components/translate/core/browser/proto/translate_ranker_model.proto

index 4ac58b4d5c7b983e344d9c364b252fd429a701af..7b25f8aec78a564b79c252b0d2a72f6ab31de699 100644

--- a/components/translate/core/browser/proto/translate_ranker_model.proto

+++ b/components/translate/core/browser/proto/translate_ranker_model.proto

@@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME;

package chrome_intelligence;

-// Defines a Chrome Ranker Translate model.

+// Defines a Chrome Ranker Translate Model.

message TranslateRankerModel {

// A number that identifies the version of this model.

optional uint32 version = 1;

@@ -29,5 +29,8 @@ message TranslateRankerModel {

map<string, float> country_weight = 7;

map<string, float> locale_weight = 8;

}

- optional LogisticRegressionModel logistic_regression_model = 2;

+ oneof model_revision {

+ LogisticRegressionModel logistic_regression_model = 2;

+ }

}