Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: ios/chrome/browser/translate/chrome_ios_translate_client.mm

Issue 2565873002: [translate] Add translate ranker model loader. (Closed)
Patch Set: comments from hamelphi Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/chrome_ios_translate_client.mm
diff --git a/ios/chrome/browser/translate/chrome_ios_translate_client.mm b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
index 6338ae52f6c605f1b2ad8902fbe3a0107fe0e092..0c84729f62bab2541182ae0fe631e30455a2b25a 100644
--- a/ios/chrome/browser/translate/chrome_ios_translate_client.mm
+++ b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
@@ -26,6 +26,7 @@
#import "ios/chrome/browser/translate/never_translate_infobar_controller.h"
#include "ios/chrome/browser/translate/translate_accept_languages_factory.h"
#import "ios/chrome/browser/translate/translate_message_infobar_controller.h"
+#include "ios/chrome/browser/translate/translate_ranker_factory.h"
#include "ios/chrome/browser/translate/translate_service_ios.h"
#include "ios/chrome/grit/ios_theme_resources.h"
#include "ios/web/public/browser_state.h"
@@ -36,8 +37,12 @@ DEFINE_WEB_STATE_USER_DATA_KEY(ChromeIOSTranslateClient);
ChromeIOSTranslateClient::ChromeIOSTranslateClient(web::WebState* web_state)
: web::WebStateObserver(web_state),
- translate_manager_(
- new translate::TranslateManager(this, prefs::kAcceptLanguages)),
+ translate_manager_(new translate::TranslateManager(
+ this,
+ translate::TranslateRankerFactory::GetInstance()->GetForBrowserState(
groby-ooo-7-16 2017/01/23 21:41:57 Will iOS actually utilize ranker?
Roger McFarlane (Chromium) 2017/02/08 23:08:14 That's the plan. Should it not?
+ ios::ChromeBrowserState::FromBrowserState(
+ web_state->GetBrowserState())),
+ prefs::kAcceptLanguages)),
translate_driver_(web_state,
web_state->GetNavigationManager(),
translate_manager_.get()) {}

Powered by Google App Engine
This is Rietveld 408576698