Index: components/translate/core/browser/proto/translate_ranker_model.proto |
diff --git a/components/translate/core/browser/proto/translate_ranker_model.proto b/components/translate/core/browser/proto/translate_ranker_model.proto |
index 4ac58b4d5c7b983e344d9c364b252fd429a701af..23904c07990aa6df88bbcf257f0edcf59749213a 100644 |
--- a/components/translate/core/browser/proto/translate_ranker_model.proto |
+++ b/components/translate/core/browser/proto/translate_ranker_model.proto |
@@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME; |
package chrome_intelligence; |
-// Defines a Chrome Ranker Translate model. |
+// Defines a Chrome Ranker Translate Model |
hamelphi
2017/01/20 18:44:18
'.'
Roger McFarlane (Chromium)
2017/02/08 23:08:09
Done.
|
message TranslateRankerModel { |
hamelphi
2017/01/20 18:44:18
IIUC, the structure of this proto will be required
Roger McFarlane (Chromium)
2017/02/08 23:08:09
There no technical requirement that other FooRanke
|
// A number that identifies the version of this model. |
optional uint32 version = 1; |
@@ -29,5 +29,6 @@ message TranslateRankerModel { |
map<string, float> country_weight = 7; |
map<string, float> locale_weight = 8; |
} |
- optional LogisticRegressionModel logistic_regression_model = 2; |
+ |
+ oneof model_iteration { LogisticRegressionModel v1 = 2; } |
hamelphi
2017/01/20 18:44:18
optional: model_revision maybe?
hamelphi
2017/01/20 18:44:18
This is not backwards compatible. I'd keep the log
Roger McFarlane (Chromium)
2017/02/08 23:08:09
Done.
Roger McFarlane (Chromium)
2017/02/08 23:08:09
This whole this isn't backwards compatible now tha
|
} |