| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "components/translate/core/browser/translate_ranker.h" | 5 #include "components/translate/core/browser/translate_ranker_impl.h" |
| 6 | 6 |
| 7 #include <initializer_list> | 7 #include <initializer_list> |
| 8 #include <memory> | 8 #include <memory> |
| 9 | 9 |
| 10 #include "base/feature_list.h" | 10 #include "base/feature_list.h" |
| 11 #include "base/memory/ptr_util.h" |
| 12 #include "base/message_loop/message_loop.h" |
| 13 #include "base/run_loop.h" |
| 11 #include "base/strings/stringprintf.h" | 14 #include "base/strings/stringprintf.h" |
| 15 #include "base/task_scheduler/post_task.h" |
| 12 #include "base/test/scoped_feature_list.h" | 16 #include "base/test/scoped_feature_list.h" |
| 17 #include "base/test/scoped_task_scheduler.h" |
| 13 #include "components/metrics/proto/translate_event.pb.h" | 18 #include "components/metrics/proto/translate_event.pb.h" |
| 14 #include "components/prefs/scoped_user_pref_update.h" | 19 #include "components/prefs/scoped_user_pref_update.h" |
| 15 #include "components/sync_preferences/testing_pref_service_syncable.h" | 20 #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 21 #include "components/translate/core/browser/proto/ranker_model.pb.h" |
| 16 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" | 22 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" |
| 17 #include "components/translate/core/browser/translate_download_manager.h" | 23 #include "components/translate/core/browser/translate_download_manager.h" |
| 18 #include "components/translate/core/browser/translate_prefs.h" | 24 #include "components/translate/core/browser/translate_prefs.h" |
| 25 #include "net/url_request/url_request_test_util.h" |
| 19 #include "testing/gtest/include/gtest/gtest.h" | 26 #include "testing/gtest/include/gtest/gtest.h" |
| 20 | 27 |
| 21 namespace translate { | 28 namespace translate { |
| 22 | 29 |
| 23 class TranslateRankerTest : public ::testing::Test { | 30 class TranslateRankerImplTest : public ::testing::Test { |
| 24 protected: | 31 protected: |
| 25 TranslateRankerTest() {} | 32 TranslateRankerImplTest() {} |
| 26 | 33 |
| 27 void SetUp() override { | 34 void SetUp() override { |
| 35 // Setup the translate download manager. |
| 28 locale_ = TranslateDownloadManager::GetInstance()->application_locale(); | 36 locale_ = TranslateDownloadManager::GetInstance()->application_locale(); |
| 37 request_context_getter_ = new net::TestURLRequestContextGetter( |
| 38 base::CreateSingleThreadTaskRunnerWithTraits(base::TaskTraits())); |
| 29 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN"); | 39 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN"); |
| 40 TranslateDownloadManager::GetInstance()->set_request_context( |
| 41 request_context_getter_.get()); |
| 30 | 42 |
| 31 // Setup a 50/50 accepted/denied count for "english" when initialize the | 43 // Setup a 50/50 accepted/denied count for "english" when initialize the |
| 32 // prefs and translate prefs. | 44 // prefs and translate prefs. |
| 33 base::DictionaryValue lang_count; | 45 base::DictionaryValue lang_count; |
| 34 lang_count.SetInteger("en", 50); | 46 lang_count.SetInteger("en", 50); |
| 35 prefs_.reset(new sync_preferences::TestingPrefServiceSyncable()); | 47 prefs_.reset(new sync_preferences::TestingPrefServiceSyncable()); |
| 36 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); | 48 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); |
| 37 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count); | 49 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count); |
| 38 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count); | 50 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count); |
| 39 translate_prefs_.reset(new TranslatePrefs( | 51 translate_prefs_.reset(new TranslatePrefs( |
| 40 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs)); | 52 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs)); |
| 41 translate_prefs_->SetCountry("us"); | 53 translate_prefs_->SetCountry("us"); |
| 42 } | 54 } |
| 43 | 55 |
| 44 void TearDown() override { | 56 void TearDown() override { |
| 57 base::RunLoop().RunUntilIdle(); |
| 45 TranslateDownloadManager::GetInstance()->set_application_locale(locale_); | 58 TranslateDownloadManager::GetInstance()->set_application_locale(locale_); |
| 59 TranslateDownloadManager::GetInstance()->set_request_context(nullptr); |
| 46 } | 60 } |
| 47 | 61 |
| 48 void InitFeatures(const std::initializer_list<base::Feature>& enabled, | 62 void InitFeatures(const std::initializer_list<base::Feature>& enabled, |
| 49 const std::initializer_list<base::Feature>& disabled) { | 63 const std::initializer_list<base::Feature>& disabled) { |
| 50 scoped_feature_list_.InitWithFeatures(enabled, disabled); | 64 scoped_feature_list_.InitWithFeatures(enabled, disabled); |
| 51 } | 65 } |
| 52 | 66 |
| 53 static std::unique_ptr<TranslateRanker> GetRankerForTest(float bias) { | 67 std::unique_ptr<TranslateRankerImpl> GetRankerForTest(float bias) { |
| 54 chrome_intelligence::TranslateRankerModel model; | 68 auto model = base::MakeUnique<chrome_intelligence::RankerModel>(); |
| 55 chrome_intelligence::TranslateRankerModel::LogisticRegressionModel* | 69 auto* details = |
| 56 details = model.mutable_logistic_regression_model(); | 70 model->mutable_translate()->mutable_logistic_regression_model(); |
| 57 details->set_bias(bias); | 71 details->set_bias(bias); |
| 58 details->set_accept_ratio_weight(0.02f); | 72 details->set_accept_ratio_weight(0.02f); |
| 59 details->set_decline_ratio_weight(0.03f); | 73 details->set_decline_ratio_weight(0.03f); |
| 60 | 74 |
| 61 auto& src_language_weight = *details->mutable_source_language_weight(); | 75 auto& src_language_weight = *details->mutable_source_language_weight(); |
| 62 src_language_weight["en"] = 0.04f; | 76 src_language_weight["en"] = 0.04f; |
| 63 src_language_weight["fr"] = 0.05f; | 77 src_language_weight["fr"] = 0.05f; |
| 64 src_language_weight["zh"] = 0.06f; | 78 src_language_weight["zh"] = 0.06f; |
| 65 | 79 |
| 66 auto& dest_language_weight = *details->mutable_dest_language_weight(); | 80 auto& dest_language_weight = *details->mutable_dest_language_weight(); |
| 67 dest_language_weight["UNKNOWN"] = 0.00f; | 81 dest_language_weight["UNKNOWN"] = 0.00f; |
| 68 | 82 |
| 69 auto& country_weight = *details->mutable_country_weight(); | 83 auto& country_weight = *details->mutable_country_weight(); |
| 70 country_weight["us"] = 0.07f; | 84 country_weight["us"] = 0.07f; |
| 71 country_weight["ca"] = 0.08f; | 85 country_weight["ca"] = 0.08f; |
| 72 country_weight["cn"] = 0.09f; | 86 country_weight["cn"] = 0.09f; |
| 73 | 87 |
| 74 auto& locale_weight = *details->mutable_locale_weight(); | 88 auto& locale_weight = *details->mutable_locale_weight(); |
| 75 locale_weight["en-us"] = 0.10f; | 89 locale_weight["en-us"] = 0.10f; |
| 76 locale_weight["en-ca"] = 0.11f; | 90 locale_weight["en-ca"] = 0.11f; |
| 77 locale_weight["zh-cn"] = 0.12f; // Normalized to lowercase. | 91 locale_weight["zh-cn"] = 0.12f; // Normalized to lowercase. |
| 78 | 92 |
| 79 return TranslateRanker::CreateForTesting(model.SerializeAsString()); | 93 auto impl = base::MakeUnique<TranslateRankerImpl>(base::FilePath(), GURL()); |
| 94 impl->OnModelAvailable(std::move(model)); |
| 95 base::RunLoop().RunUntilIdle(); |
| 96 return impl; |
| 80 } | 97 } |
| 81 | 98 |
| 82 static double Sigmoid(double x) { return 1.0 / (1.0 + exp(-x)); } | 99 static double Sigmoid(double x) { return 1.0 / (1.0 + exp(-x)); } |
| 83 | 100 |
| 84 static metrics::TranslateEventProto CreateTranslateEvent( | 101 static metrics::TranslateEventProto CreateTranslateEvent( |
| 85 const std::string& src_lang, | 102 const std::string& src_lang, |
| 86 const std::string& dst_lang, | 103 const std::string& dst_lang, |
| 87 int accept_count, | 104 int accept_count, |
| 88 int decline_count, | 105 int decline_count, |
| 89 int ignore_count) { | 106 int ignore_count) { |
| 90 metrics::TranslateEventProto translate_event; | 107 metrics::TranslateEventProto translate_event; |
| 91 translate_event.set_source_language(src_lang); | 108 translate_event.set_source_language(src_lang); |
| 92 translate_event.set_target_language(dst_lang); | 109 translate_event.set_target_language(dst_lang); |
| 93 translate_event.set_accept_count(accept_count); | 110 translate_event.set_accept_count(accept_count); |
| 94 translate_event.set_decline_count(decline_count); | 111 translate_event.set_decline_count(decline_count); |
| 95 translate_event.set_ignore_count(ignore_count); | 112 translate_event.set_ignore_count(ignore_count); |
| 96 return translate_event; | 113 return translate_event; |
| 97 } | 114 } |
| 98 | 115 |
| 99 static const char* const kPreferredLanguagePrefs; | 116 static const char* const kPreferredLanguagePrefs; |
| 100 | 117 |
| 118 // Prefs. |
| 101 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_; | 119 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_; |
| 102 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; | 120 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; |
| 103 | 121 |
| 104 private: | 122 private: |
| 123 // Sets up the task scheduling/task-runner environment for each test. |
| 124 base::test::ScopedTaskScheduler scoped_task_scheduler_; |
| 125 |
| 105 // Manages the enabling/disabling of features within the scope of a test. | 126 // Manages the enabling/disabling of features within the scope of a test. |
| 106 base::test::ScopedFeatureList scoped_feature_list_; | 127 base::test::ScopedFeatureList scoped_feature_list_; |
| 107 | 128 |
| 108 // Cache and reset the application locale for each test. | 129 // Cache and reset the application locale for each test. |
| 109 std::string locale_; | 130 std::string locale_; |
| 110 | 131 |
| 111 DISALLOW_COPY_AND_ASSIGN(TranslateRankerTest); | 132 // Used to initialize the translate download manager. |
| 133 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; |
| 134 |
| 135 DISALLOW_COPY_AND_ASSIGN(TranslateRankerImplTest); |
| 112 }; | 136 }; |
| 113 | 137 |
| 114 const char* const TranslateRankerTest::kPreferredLanguagePrefs = | 138 const char* const TranslateRankerImplTest::kPreferredLanguagePrefs = |
| 115 #if defined(OS_CHROMEOS) | 139 #if defined(OS_CHROMEOS) |
| 116 "settings.language.preferred_languages"; | 140 "settings.language.preferred_languages"; |
| 117 #else | 141 #else |
| 118 nullptr; | 142 nullptr; |
| 119 #endif | 143 #endif |
| 120 | 144 |
| 121 TEST_F(TranslateRankerTest, DisabledByDefault) { | 145 TEST_F(TranslateRankerImplTest, DisabledByDefault) { |
| 122 InitFeatures({}, {}); | 146 InitFeatures({}, {}); |
| 123 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 147 EXPECT_FALSE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 148 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 149 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 124 } | 150 } |
| 125 | 151 |
| 126 TEST_F(TranslateRankerTest, Disabled) { | 152 TEST_F(TranslateRankerImplTest, ExplicitlyDisabled) { |
| 127 InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement}); | 153 InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement, |
| 128 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 154 kTranslateRankerLogging}); |
| 155 EXPECT_FALSE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 156 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 157 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 129 } | 158 } |
| 130 | 159 |
| 131 TEST_F(TranslateRankerTest, EnableQuery) { | 160 TEST_F(TranslateRankerImplTest, EnableQuery) { |
| 132 InitFeatures({kTranslateRankerQuery}, {kTranslateRankerEnforcement}); | 161 InitFeatures({kTranslateRankerQuery}, {kTranslateRankerEnforcement}); |
| 133 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 162 EXPECT_TRUE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 163 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 164 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 134 } | 165 } |
| 135 | 166 |
| 136 TEST_F(TranslateRankerTest, EnableEnforcement) { | 167 TEST_F(TranslateRankerImplTest, EnableEnforcement) { |
| 137 InitFeatures({kTranslateRankerEnforcement}, {kTranslateRankerQuery}); | 168 InitFeatures({kTranslateRankerEnforcement}, {kTranslateRankerQuery}); |
| 138 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 169 EXPECT_TRUE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 170 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 171 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 139 } | 172 } |
| 140 | 173 |
| 141 TEST_F(TranslateRankerTest, EnableQueryAndEnforcement) { | 174 TEST_F(TranslateRankerImplTest, EnableQueryAndEnforcement) { |
| 142 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 175 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
| 143 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 176 EXPECT_TRUE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 144 EXPECT_FALSE(TranslateRanker::IsLoggingEnabled()); | 177 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 178 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 145 } | 179 } |
| 146 | 180 |
| 147 TEST_F(TranslateRankerTest, EnableLogging) { | 181 TEST_F(TranslateRankerImplTest, EnableLogging) { |
| 148 InitFeatures({kTranslateRankerLogging}, {}); | 182 InitFeatures({kTranslateRankerLogging}, {}); |
| 149 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 183 EXPECT_TRUE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 150 EXPECT_TRUE(TranslateRanker::IsLoggingEnabled()); | 184 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 185 EXPECT_TRUE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 151 } | 186 } |
| 152 | 187 |
| 188 TEST_F(TranslateRankerImplTest, EnableAll) { |
| 189 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement, |
| 190 kTranslateRankerLogging}, |
| 191 {}); |
| 192 EXPECT_TRUE(GetRankerForTest(0.5)->IsQueryEnabled()); |
| 193 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnforcementEnabled()); |
| 194 EXPECT_TRUE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
| 195 } |
| 153 | 196 |
| 154 TEST_F(TranslateRankerTest, CalculateScore) { | 197 TEST_F(TranslateRankerImplTest, CalculateScore) { |
| 155 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 198 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
| 156 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.01f); | 199 auto ranker = GetRankerForTest(0.01f); |
| 157 // Calculate the score using: a 50:50 accept/decline ratio; the one-hot | 200 // Calculate the score using: a 50:50 accept/decline ratio; the one-hot |
| 158 // values for the src lang, dest lang, locale and counry; and, the bias. | 201 // values for the src lang, dest lang, locale and counry; and, the bias. |
| 159 double expected = Sigmoid(0.5 * 0.02f + // accept ratio * weight | 202 double expected = Sigmoid(0.5 * 0.02f + // accept ratio * weight |
| 160 0.5 * 0.03f + // decline ratio * weight | 203 0.5 * 0.03f + // decline ratio * weight |
| 161 0.0 * 0.00f + // ignore ratio * (default) weight | 204 0.0 * 0.00f + // ignore ratio * (default) weight |
| 162 1.0 * 0.04f + // one-hot src-language "en" * weight | 205 1.0 * 0.04f + // one-hot src-language "en" * weight |
| 163 1.0 * 0.00f + // one-hot dst-language "fr" * weight | 206 1.0 * 0.00f + // one-hot dst-language "fr" * weight |
| 164 1.0 * 0.07f + // one-hot country * weight | 207 1.0 * 0.07f + // one-hot country * weight |
| 165 1.0 * 0.12f + // one-hot locale * weight | 208 1.0 * 0.12f + // one-hot locale * weight |
| 166 0.01f); // bias | 209 0.01f); // bias |
| 210 TranslateRankerFeatures features; |
| 211 features.src_lang = "en"; |
| 212 features.dst_lang = "fr"; |
| 213 features.country = "us"; |
| 214 features.app_locale = "zh-CN"; |
| 215 features.accepted_ratio = 0.5; |
| 216 features.denied_ratio = 0.5; |
| 217 features.ignored_ratio = 0.0; |
| 167 | 218 |
| 168 EXPECT_NEAR(expected, | 219 EXPECT_NEAR(expected, ranker->CalculateScore(features), 0.000001); |
| 169 ranker->CalculateScore(0.5, 0.5, 0.0, "en", "fr", "zh-CN", "us"), | |
| 170 0.000001); | |
| 171 } | 220 } |
| 172 | 221 |
| 173 TEST_F(TranslateRankerTest, ShouldOfferTranslation) { | 222 TEST_F(TranslateRankerImplTest, ShouldOfferTranslation) { |
| 174 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 223 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
| 175 // With a bias of -0.5 en->fr is not over the threshold. | 224 // With a bias of -0.5 en->fr is not over the threshold. |
| 176 EXPECT_FALSE(GetRankerForTest(-0.5f)->ShouldOfferTranslation( | 225 EXPECT_FALSE(GetRankerForTest(-0.5f)->ShouldOfferTranslation( |
| 177 *translate_prefs_, "en", "fr")); | 226 *translate_prefs_, "en", "fr")); |
| 178 // With a bias of 0.25 en-fr is over the threshold. | 227 // With a bias of 0.25 en-fr is over the threshold. |
| 179 EXPECT_TRUE(GetRankerForTest(0.25f)->ShouldOfferTranslation(*translate_prefs_, | 228 EXPECT_TRUE(GetRankerForTest(0.25f)->ShouldOfferTranslation(*translate_prefs_, |
| 180 "en", "fr")); | 229 "en", "fr")); |
| 181 } | 230 } |
| 182 | 231 |
| 183 TEST_F(TranslateRankerTest, RecordAndFlushEvents) { | 232 TEST_F(TranslateRankerImplTest, RecordAndFlushEvents) { |
| 184 InitFeatures({kTranslateRankerLogging}, {}); | 233 InitFeatures({kTranslateRankerLogging}, {}); |
| 185 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); | 234 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); |
| 186 std::vector<metrics::TranslateEventProto> flushed_events; | 235 std::vector<metrics::TranslateEventProto> flushed_events; |
| 187 | 236 |
| 188 // Check that flushing an empty cache will return an empty vector. | 237 // Check that flushing an empty cache will return an empty vector. |
| 189 ranker->FlushTranslateEvents(&flushed_events); | 238 ranker->FlushTranslateEvents(&flushed_events); |
| 190 EXPECT_EQ(0U, flushed_events.size()); | 239 EXPECT_EQ(0U, flushed_events.size()); |
| 191 | 240 |
| 192 auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3); | 241 ranker->AddTranslateEvent(CreateTranslateEvent("fr", "en", 1, 0, 3)); |
| 193 auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3); | 242 ranker->AddTranslateEvent(CreateTranslateEvent("jp", "en", 2, 0, 3)); |
| 194 auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6); | 243 ranker->AddTranslateEvent(CreateTranslateEvent("es", "de", 4, 5, 6)); |
| 195 ranker->RecordTranslateEvent(event_1); | |
| 196 ranker->RecordTranslateEvent(event_2); | |
| 197 ranker->RecordTranslateEvent(event_3); | |
| 198 | 244 |
| 199 // Capture the data and verify that it is as expected. | 245 // Capture the data and verify that it is as expected. |
| 200 ranker->FlushTranslateEvents(&flushed_events); | 246 ranker->FlushTranslateEvents(&flushed_events); |
| 201 EXPECT_EQ(3U, flushed_events.size()); | 247 EXPECT_EQ(3U, flushed_events.size()); |
| 202 ASSERT_EQ("fr", flushed_events[0].source_language()); | 248 ASSERT_EQ("fr", flushed_events[0].source_language()); |
| 203 ASSERT_EQ("jp", flushed_events[1].source_language()); | 249 ASSERT_EQ("jp", flushed_events[1].source_language()); |
| 204 ASSERT_EQ("es", flushed_events[2].source_language()); | 250 ASSERT_EQ("es", flushed_events[2].source_language()); |
| 205 | 251 |
| 206 // Check that the cache has been cleared. | 252 // Check that the cache has been cleared. |
| 207 ranker->FlushTranslateEvents(&flushed_events); | 253 ranker->FlushTranslateEvents(&flushed_events); |
| 208 EXPECT_EQ(0U, flushed_events.size()); | 254 EXPECT_EQ(0U, flushed_events.size()); |
| 209 } | 255 } |
| 210 | 256 |
| 211 TEST_F(TranslateRankerTest, LoggingDisabled) { | 257 TEST_F(TranslateRankerImplTest, LoggingDisabled) { |
| 212 InitFeatures({}, {kTranslateRankerLogging}); | 258 InitFeatures({}, {kTranslateRankerLogging}); |
| 213 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); | 259 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); |
| 214 std::vector<metrics::TranslateEventProto> flushed_events; | 260 std::vector<metrics::TranslateEventProto> flushed_events; |
| 215 | 261 |
| 216 ranker->FlushTranslateEvents(&flushed_events); | 262 ranker->FlushTranslateEvents(&flushed_events); |
| 217 EXPECT_EQ(0U, flushed_events.size()); | 263 EXPECT_EQ(0U, flushed_events.size()); |
| 218 | 264 |
| 219 auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3); | 265 ranker->AddTranslateEvent(CreateTranslateEvent("fr", "en", 1, 0, 3)); |
| 220 auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3); | 266 ranker->AddTranslateEvent(CreateTranslateEvent("jp", "en", 2, 0, 3)); |
| 221 auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6); | 267 ranker->AddTranslateEvent(CreateTranslateEvent("es", "de", 4, 5, 6)); |
| 222 ranker->RecordTranslateEvent(event_1); | |
| 223 ranker->RecordTranslateEvent(event_2); | |
| 224 ranker->RecordTranslateEvent(event_3); | |
| 225 | 268 |
| 226 // Logging is disabled, so no events should be cached. | 269 // Logging is disabled, so no events should be cached. |
| 227 ranker->FlushTranslateEvents(&flushed_events); | 270 ranker->FlushTranslateEvents(&flushed_events); |
| 228 EXPECT_EQ(0U, flushed_events.size()); | 271 EXPECT_EQ(0U, flushed_events.size()); |
| 229 } | 272 } |
| 230 | 273 |
| 231 } // namespace translate | 274 } // namespace translate |
| OLD | NEW |