OLD | NEW |
1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "components/translate/core/browser/translate_ranker.h" | 5 #include "components/translate/core/browser/translate_ranker_impl.h" |
6 | 6 |
7 #include <initializer_list> | 7 #include <initializer_list> |
8 #include <memory> | 8 #include <memory> |
9 | 9 |
10 #include "base/feature_list.h" | 10 #include "base/feature_list.h" |
| 11 #include "base/memory/ptr_util.h" |
| 12 #include "base/message_loop/message_loop.h" |
11 #include "base/strings/stringprintf.h" | 13 #include "base/strings/stringprintf.h" |
12 #include "base/test/scoped_feature_list.h" | 14 #include "base/test/scoped_feature_list.h" |
| 15 #include "base/test/test_simple_task_runner.h" |
| 16 #include "base/threading/thread_task_runner_handle.h" |
13 #include "components/metrics/proto/translate_event.pb.h" | 17 #include "components/metrics/proto/translate_event.pb.h" |
14 #include "components/prefs/scoped_user_pref_update.h" | 18 #include "components/prefs/scoped_user_pref_update.h" |
15 #include "components/sync_preferences/testing_pref_service_syncable.h" | 19 #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 20 #include "components/translate/core/browser/proto/ranker_model.pb.h" |
16 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" | 21 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" |
17 #include "components/translate/core/browser/translate_download_manager.h" | 22 #include "components/translate/core/browser/translate_download_manager.h" |
18 #include "components/translate/core/browser/translate_prefs.h" | 23 #include "components/translate/core/browser/translate_prefs.h" |
19 #include "testing/gtest/include/gtest/gtest.h" | 24 #include "testing/gtest/include/gtest/gtest.h" |
20 | 25 |
21 namespace translate { | 26 namespace translate { |
22 | 27 |
23 class TranslateRankerTest : public ::testing::Test { | 28 class TranslateRankerImplTest : public ::testing::Test { |
24 protected: | 29 protected: |
25 TranslateRankerTest() {} | 30 TranslateRankerImplTest() {} |
26 | 31 |
27 void SetUp() override { | 32 void SetUp() override { |
| 33 // Setup the task runner environment. |
| 34 task_runner_ = new base::TestSimpleTaskRunner(); |
| 35 thread_task_runner_handle_ = |
| 36 base::MakeUnique<base::ThreadTaskRunnerHandle>(task_runner_); |
| 37 |
| 38 // Setup the application locale. |
28 locale_ = TranslateDownloadManager::GetInstance()->application_locale(); | 39 locale_ = TranslateDownloadManager::GetInstance()->application_locale(); |
29 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN"); | 40 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN"); |
30 | 41 |
31 // Setup a 50/50 accepted/denied count for "english" when initialize the | 42 // Setup a 50/50 accepted/denied count for "english" when initialize the |
32 // prefs and translate prefs. | 43 // prefs and translate prefs. |
33 base::DictionaryValue lang_count; | 44 base::DictionaryValue lang_count; |
34 lang_count.SetInteger("en", 50); | 45 lang_count.SetInteger("en", 50); |
35 prefs_.reset(new sync_preferences::TestingPrefServiceSyncable()); | 46 prefs_.reset(new sync_preferences::TestingPrefServiceSyncable()); |
36 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); | 47 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); |
37 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count); | 48 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count); |
38 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count); | 49 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count); |
39 translate_prefs_.reset(new TranslatePrefs( | 50 translate_prefs_.reset(new TranslatePrefs( |
40 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs)); | 51 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs)); |
41 translate_prefs_->SetCountry("us"); | 52 translate_prefs_->SetCountry("us"); |
42 } | 53 } |
43 | 54 |
44 void TearDown() override { | 55 void TearDown() override { |
45 TranslateDownloadManager::GetInstance()->set_application_locale(locale_); | 56 TranslateDownloadManager::GetInstance()->set_application_locale(locale_); |
46 } | 57 } |
47 | 58 |
48 void InitFeatures(const std::initializer_list<base::Feature>& enabled, | 59 void InitFeatures(const std::initializer_list<base::Feature>& enabled, |
49 const std::initializer_list<base::Feature>& disabled) { | 60 const std::initializer_list<base::Feature>& disabled) { |
50 scoped_feature_list_.InitWithFeatures(enabled, disabled); | 61 scoped_feature_list_.InitWithFeatures(enabled, disabled); |
51 } | 62 } |
52 | 63 |
53 static std::unique_ptr<TranslateRanker> GetRankerForTest(float bias) { | 64 std::unique_ptr<TranslateRankerImpl> GetRankerForTest(float bias) { |
54 chrome_intelligence::TranslateRankerModel model; | 65 auto model = base::MakeUnique<chrome_intelligence::RankerModel>(); |
55 chrome_intelligence::TranslateRankerModel::LogisticRegressionModel* | 66 auto* details = |
56 details = model.mutable_logistic_regression_model(); | 67 model->mutable_translate()->mutable_logistic_regression_model(); |
57 details->set_bias(bias); | 68 details->set_bias(bias); |
58 details->set_accept_ratio_weight(0.02f); | 69 details->set_accept_ratio_weight(0.02f); |
59 details->set_decline_ratio_weight(0.03f); | 70 details->set_decline_ratio_weight(0.03f); |
60 | 71 |
61 auto& src_language_weight = *details->mutable_source_language_weight(); | 72 auto& src_language_weight = *details->mutable_source_language_weight(); |
62 src_language_weight["en"] = 0.04f; | 73 src_language_weight["en"] = 0.04f; |
63 src_language_weight["fr"] = 0.05f; | 74 src_language_weight["fr"] = 0.05f; |
64 src_language_weight["zh"] = 0.06f; | 75 src_language_weight["zh"] = 0.06f; |
65 | 76 |
66 auto& dest_language_weight = *details->mutable_dest_language_weight(); | 77 auto& dest_language_weight = *details->mutable_dest_language_weight(); |
67 dest_language_weight["UNKNOWN"] = 0.00f; | 78 dest_language_weight["UNKNOWN"] = 0.00f; |
68 | 79 |
69 auto& country_weight = *details->mutable_country_weight(); | 80 auto& country_weight = *details->mutable_country_weight(); |
70 country_weight["us"] = 0.07f; | 81 country_weight["us"] = 0.07f; |
71 country_weight["ca"] = 0.08f; | 82 country_weight["ca"] = 0.08f; |
72 country_weight["cn"] = 0.09f; | 83 country_weight["cn"] = 0.09f; |
73 | 84 |
74 auto& locale_weight = *details->mutable_locale_weight(); | 85 auto& locale_weight = *details->mutable_locale_weight(); |
75 locale_weight["en-us"] = 0.10f; | 86 locale_weight["en-us"] = 0.10f; |
76 locale_weight["en-ca"] = 0.11f; | 87 locale_weight["en-ca"] = 0.11f; |
77 locale_weight["zh-cn"] = 0.12f; // Normalized to lowercase. | 88 locale_weight["zh-cn"] = 0.12f; // Normalized to lowercase. |
78 | 89 |
79 return TranslateRanker::CreateForTesting(model.SerializeAsString()); | 90 auto impl = base::MakeUnique<TranslateRankerImpl>(base::FilePath(), GURL()); |
| 91 impl->OnModelAvailable(std::move(model)); |
| 92 task_runner_->RunUntilIdle(); |
| 93 return impl; |
80 } | 94 } |
81 | 95 |
82 static double Sigmoid(double x) { return 1.0 / (1.0 + exp(-x)); } | 96 static double Sigmoid(double x) { return 1.0 / (1.0 + exp(-x)); } |
83 | 97 |
84 static metrics::TranslateEventProto CreateTranslateEvent( | 98 static std::unique_ptr<metrics::TranslateEventProto> CreateTranslateEvent( |
85 const std::string& src_lang, | 99 const std::string& src_lang, |
86 const std::string& dst_lang, | 100 const std::string& dst_lang, |
87 int accept_count, | 101 int accept_count, |
88 int decline_count, | 102 int decline_count, |
89 int ignore_count) { | 103 int ignore_count) { |
90 metrics::TranslateEventProto translate_event; | 104 auto translate_event = base::MakeUnique<metrics::TranslateEventProto>(); |
91 translate_event.set_source_language(src_lang); | 105 translate_event->set_source_language(src_lang); |
92 translate_event.set_target_language(dst_lang); | 106 translate_event->set_target_language(dst_lang); |
93 translate_event.set_accept_count(accept_count); | 107 translate_event->set_accept_count(accept_count); |
94 translate_event.set_decline_count(decline_count); | 108 translate_event->set_decline_count(decline_count); |
95 translate_event.set_ignore_count(ignore_count); | 109 translate_event->set_ignore_count(ignore_count); |
96 return translate_event; | 110 return translate_event; |
97 } | 111 } |
98 | 112 |
99 static const char* const kPreferredLanguagePrefs; | 113 static const char* const kPreferredLanguagePrefs; |
100 | 114 |
| 115 // To setup the task scheduling/task-runner environment for each test. |
| 116 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; |
| 117 std::unique_ptr<base::ThreadTaskRunnerHandle> thread_task_runner_handle_; |
| 118 |
| 119 // Prefs. |
101 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_; | 120 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_; |
102 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; | 121 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; |
103 | 122 |
104 private: | 123 private: |
105 // Manages the enabling/disabling of features within the scope of a test. | 124 // Manages the enabling/disabling of features within the scope of a test. |
106 base::test::ScopedFeatureList scoped_feature_list_; | 125 base::test::ScopedFeatureList scoped_feature_list_; |
107 | 126 |
108 // Cache and reset the application locale for each test. | 127 // Cache and reset the application locale for each test. |
109 std::string locale_; | 128 std::string locale_; |
110 | 129 |
111 DISALLOW_COPY_AND_ASSIGN(TranslateRankerTest); | 130 DISALLOW_COPY_AND_ASSIGN(TranslateRankerImplTest); |
112 }; | 131 }; |
113 | 132 |
114 const char* const TranslateRankerTest::kPreferredLanguagePrefs = | 133 const char* const TranslateRankerImplTest::kPreferredLanguagePrefs = |
115 #if defined(OS_CHROMEOS) | 134 #if defined(OS_CHROMEOS) |
116 "settings.language.preferred_languages"; | 135 "settings.language.preferred_languages"; |
117 #else | 136 #else |
118 nullptr; | 137 nullptr; |
119 #endif | 138 #endif |
120 | 139 |
121 TEST_F(TranslateRankerTest, DisabledByDefault) { | 140 TEST_F(TranslateRankerImplTest, DisabledByDefault) { |
122 InitFeatures({}, {}); | 141 InitFeatures({}, {}); |
123 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 142 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnabled()); |
124 } | 143 } |
125 | 144 |
126 TEST_F(TranslateRankerTest, Disabled) { | 145 TEST_F(TranslateRankerImplTest, Disabled) { |
127 InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement}); | 146 InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement}); |
128 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 147 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnabled()); |
129 } | 148 } |
130 | 149 |
131 TEST_F(TranslateRankerTest, EnableQuery) { | 150 TEST_F(TranslateRankerImplTest, EnableQuery) { |
132 InitFeatures({kTranslateRankerQuery}, {kTranslateRankerEnforcement}); | 151 InitFeatures({kTranslateRankerQuery}, {kTranslateRankerEnforcement}); |
133 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 152 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnabled()); |
134 } | 153 } |
135 | 154 |
136 TEST_F(TranslateRankerTest, EnableEnforcement) { | 155 TEST_F(TranslateRankerImplTest, EnableEnforcement) { |
137 InitFeatures({kTranslateRankerEnforcement}, {kTranslateRankerQuery}); | 156 InitFeatures({kTranslateRankerEnforcement}, {kTranslateRankerQuery}); |
138 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 157 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnabled()); |
139 } | 158 } |
140 | 159 |
141 TEST_F(TranslateRankerTest, EnableQueryAndEnforcement) { | 160 TEST_F(TranslateRankerImplTest, EnableQueryAndEnforcement) { |
142 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 161 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
143 EXPECT_TRUE(TranslateRanker::IsEnabled()); | 162 EXPECT_TRUE(GetRankerForTest(0.5)->IsEnabled()); |
144 EXPECT_FALSE(TranslateRanker::IsLoggingEnabled()); | 163 EXPECT_FALSE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
145 } | 164 } |
146 | 165 |
147 TEST_F(TranslateRankerTest, EnableLogging) { | 166 TEST_F(TranslateRankerImplTest, EnableLogging) { |
148 InitFeatures({kTranslateRankerLogging}, {}); | 167 InitFeatures({kTranslateRankerLogging}, {}); |
149 EXPECT_FALSE(TranslateRanker::IsEnabled()); | 168 EXPECT_FALSE(GetRankerForTest(0.5)->IsEnabled()); |
150 EXPECT_TRUE(TranslateRanker::IsLoggingEnabled()); | 169 EXPECT_TRUE(GetRankerForTest(0.5)->IsLoggingEnabled()); |
151 } | 170 } |
152 | 171 |
153 | 172 TEST_F(TranslateRankerImplTest, CalculateScore) { |
154 TEST_F(TranslateRankerTest, CalculateScore) { | |
155 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 173 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
156 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.01f); | 174 auto ranker = GetRankerForTest(0.01f); |
157 // Calculate the score using: a 50:50 accept/decline ratio; the one-hot | 175 // Calculate the score using: a 50:50 accept/decline ratio; the one-hot |
158 // values for the src lang, dest lang, locale and counry; and, the bias. | 176 // values for the src lang, dest lang, locale and counry; and, the bias. |
159 double expected = Sigmoid(0.5 * 0.02f + // accept ratio * weight | 177 double expected = Sigmoid(0.5 * 0.02f + // accept ratio * weight |
160 0.5 * 0.03f + // decline ratio * weight | 178 0.5 * 0.03f + // decline ratio * weight |
161 0.0 * 0.00f + // ignore ratio * (default) weight | 179 0.0 * 0.00f + // ignore ratio * (default) weight |
162 1.0 * 0.04f + // one-hot src-language "en" * weight | 180 1.0 * 0.04f + // one-hot src-language "en" * weight |
163 1.0 * 0.00f + // one-hot dst-language "fr" * weight | 181 1.0 * 0.00f + // one-hot dst-language "fr" * weight |
164 1.0 * 0.07f + // one-hot country * weight | 182 1.0 * 0.07f + // one-hot country * weight |
165 1.0 * 0.12f + // one-hot locale * weight | 183 1.0 * 0.12f + // one-hot locale * weight |
166 0.01f); // bias | 184 0.01f); // bias |
| 185 TranslateRankerFeatures features; |
| 186 features.src_lang = "en"; |
| 187 features.dst_lang = "fr"; |
| 188 features.country = "us"; |
| 189 features.app_locale = "zh-CN"; |
| 190 features.accepted_ratio = 0.5; |
| 191 features.denied_ratio = 0.5; |
| 192 features.ignored_ratio = 0.0; |
167 | 193 |
168 EXPECT_NEAR(expected, | 194 EXPECT_NEAR(expected, ranker->CalculateScore(features), 0.000001); |
169 ranker->CalculateScore(0.5, 0.5, 0.0, "en", "fr", "zh-CN", "us"), | |
170 0.000001); | |
171 } | 195 } |
172 | 196 |
173 TEST_F(TranslateRankerTest, ShouldOfferTranslation) { | 197 TEST_F(TranslateRankerImplTest, ShouldOfferTranslation) { |
174 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); | 198 InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {}); |
175 // With a bias of -0.5 en->fr is not over the threshold. | 199 // With a bias of -0.5 en->fr is not over the threshold. |
176 EXPECT_FALSE(GetRankerForTest(-0.5f)->ShouldOfferTranslation( | 200 EXPECT_FALSE(GetRankerForTest(-0.5f)->ShouldOfferTranslation( |
177 *translate_prefs_, "en", "fr")); | 201 *translate_prefs_, "en", "fr")); |
178 // With a bias of 0.25 en-fr is over the threshold. | 202 // With a bias of 0.25 en-fr is over the threshold. |
179 EXPECT_TRUE(GetRankerForTest(0.25f)->ShouldOfferTranslation(*translate_prefs_, | 203 EXPECT_TRUE(GetRankerForTest(0.25f)->ShouldOfferTranslation(*translate_prefs_, |
180 "en", "fr")); | 204 "en", "fr")); |
181 } | 205 } |
182 | 206 |
183 TEST_F(TranslateRankerTest, RecordAndFlushEvents) { | 207 TEST_F(TranslateRankerImplTest, RecordAndFlushEvents) { |
184 InitFeatures({kTranslateRankerLogging}, {}); | 208 InitFeatures({kTranslateRankerLogging}, {}); |
185 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); | 209 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); |
186 std::vector<metrics::TranslateEventProto> flushed_events; | 210 std::vector<std::unique_ptr<metrics::TranslateEventProto>> flushed_events; |
187 | 211 |
188 // Check that flushing an empty cache will return an empty vector. | 212 // Check that flushing an empty cache will return an empty vector. |
189 ranker->FlushTranslateEvents(&flushed_events); | 213 ranker->FlushTranslateEvents(&flushed_events); |
190 EXPECT_EQ(0U, flushed_events.size()); | 214 EXPECT_EQ(0U, flushed_events.size()); |
191 | 215 |
192 auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3); | 216 ranker->AddTranslateEvent(CreateTranslateEvent("fr", "en", 1, 0, 3)); |
193 auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3); | 217 ranker->AddTranslateEvent(CreateTranslateEvent("jp", "en", 2, 0, 3)); |
194 auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6); | 218 ranker->AddTranslateEvent(CreateTranslateEvent("es", "de", 4, 5, 6)); |
195 ranker->RecordTranslateEvent(event_1); | |
196 ranker->RecordTranslateEvent(event_2); | |
197 ranker->RecordTranslateEvent(event_3); | |
198 | 219 |
199 // Capture the data and verify that it is as expected. | 220 // Capture the data and verify that it is as expected. |
200 ranker->FlushTranslateEvents(&flushed_events); | 221 ranker->FlushTranslateEvents(&flushed_events); |
201 EXPECT_EQ(3U, flushed_events.size()); | 222 EXPECT_EQ(3U, flushed_events.size()); |
202 ASSERT_EQ("fr", flushed_events[0].source_language()); | 223 ASSERT_EQ("fr", flushed_events[0]->source_language()); |
203 ASSERT_EQ("jp", flushed_events[1].source_language()); | 224 ASSERT_EQ("jp", flushed_events[1]->source_language()); |
204 ASSERT_EQ("es", flushed_events[2].source_language()); | 225 ASSERT_EQ("es", flushed_events[2]->source_language()); |
205 | 226 |
206 // Check that the cache has been cleared. | 227 // Check that the cache has been cleared. |
207 ranker->FlushTranslateEvents(&flushed_events); | 228 ranker->FlushTranslateEvents(&flushed_events); |
208 EXPECT_EQ(0U, flushed_events.size()); | 229 EXPECT_EQ(0U, flushed_events.size()); |
209 } | 230 } |
210 | 231 |
211 TEST_F(TranslateRankerTest, LoggingDisabled) { | 232 TEST_F(TranslateRankerImplTest, LoggingDisabled) { |
212 InitFeatures({}, {kTranslateRankerLogging}); | 233 InitFeatures({}, {kTranslateRankerLogging}); |
213 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); | 234 std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f); |
214 std::vector<metrics::TranslateEventProto> flushed_events; | 235 std::vector<std::unique_ptr<metrics::TranslateEventProto>> flushed_events; |
215 | 236 |
216 ranker->FlushTranslateEvents(&flushed_events); | 237 ranker->FlushTranslateEvents(&flushed_events); |
217 EXPECT_EQ(0U, flushed_events.size()); | 238 EXPECT_EQ(0U, flushed_events.size()); |
218 | 239 |
219 auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3); | 240 ranker->AddTranslateEvent(CreateTranslateEvent("fr", "en", 1, 0, 3)); |
220 auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3); | 241 ranker->AddTranslateEvent(CreateTranslateEvent("jp", "en", 2, 0, 3)); |
221 auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6); | 242 ranker->AddTranslateEvent(CreateTranslateEvent("es", "de", 4, 5, 6)); |
222 ranker->RecordTranslateEvent(event_1); | |
223 ranker->RecordTranslateEvent(event_2); | |
224 ranker->RecordTranslateEvent(event_3); | |
225 | 243 |
226 // Logging is disabled, so no events should be cached. | 244 // Logging is disabled, so no events should be cached. |
227 ranker->FlushTranslateEvents(&flushed_events); | 245 ranker->FlushTranslateEvents(&flushed_events); |
228 EXPECT_EQ(0U, flushed_events.size()); | 246 EXPECT_EQ(0U, flushed_events.size()); |
229 } | 247 } |
230 | 248 |
231 } // namespace translate | 249 } // namespace translate |
OLD | NEW |