Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2565853002: Add //build/util:chrome_version_json to chrome_public_apk dependency (Closed)

Created:
4 years ago by F
Modified:
4 years ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //build/util:chrome_version_json to chrome_public_apk dependency Add native_lib_version_rule = "//build/util:chrome_version_json" to chrome_public_apk to fix the build failure caused by "No such file or directory: 'gen/CHROME_VERSION.json'" when building monochrome_public_apk in a fresh output directory. Committed: https://crrev.com/b5978cb45a67544143fc253165cc14491f7ce23e Cr-Commit-Position: refs/heads/master@{#437679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
F
Hi Andrew, PTAL. Thanks!
4 years ago (2016-12-09 20:36:24 UTC) #3
F
Hi Andrew, PTAL. Thanks!
4 years ago (2016-12-09 20:36:46 UTC) #5
agrieve
On 2016/12/09 20:36:46, F wrote: > Hi Andrew, PTAL. Thanks! lgtm
4 years ago (2016-12-09 21:06:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565853002/1
4 years ago (2016-12-09 21:28:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:04:12 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 14:57:56 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5978cb45a67544143fc253165cc14491f7ce23e
Cr-Commit-Position: refs/heads/master@{#437679}

Powered by Google App Engine
This is Rietveld 408576698