Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: net/ssl/ssl_platform_key_util.cc

Issue 2565843002: Add missing logging codepaths for client certificate lookup. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/ssl_platform_key_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_platform_key_util.cc
diff --git a/net/ssl/ssl_platform_key_util.cc b/net/ssl/ssl_platform_key_util.cc
index 3e6469831ec8c006dc46db8257ecfe3244240d0e..6c76220d431da74beed73f66da89cc01141766a8 100644
--- a/net/ssl/ssl_platform_key_util.cc
+++ b/net/ssl/ssl_platform_key_util.cc
@@ -71,7 +71,8 @@ bool GetClientCertInfo(const X509Certificate* certificate,
return false;
}
- switch (EVP_PKEY_id(key.get())) {
+ int key_type = EVP_PKEY_id(key.get());
+ switch (key_type) {
case EVP_PKEY_RSA:
*out_type = SSLPrivateKey::Type::RSA;
break;
@@ -90,12 +91,14 @@ bool GetClientCertInfo(const X509Certificate* certificate,
*out_type = SSLPrivateKey::Type::ECDSA_P384;
break;
default:
+ LOG(ERROR) << "Unsupported curve type " << curve;
return false;
}
break;
}
default:
+ LOG(ERROR) << "Unsupported key type " << key_type;
return false;
}
« no previous file with comments | « net/ssl/ssl_platform_key_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698