Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: media/filters/chunk_demuxer.h

Issue 256583006: Fix possible buffer emission during an abort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address CR comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index c0889f661cdabe89fead53f590ee7e8ce32ea9dc..4095fee085940f8e93ce1527f6a10c6caeb79158 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -220,7 +220,12 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// Aborts parsing the current segment and reset the parser to a state where
// it can accept a new segment.
- void Abort(const std::string& id);
+ // Some pending frames can be emitted during that process. These frames are
+ // applied |timestamp_offset|.
+ void Abort(const std::string& id,
+ base::TimeDelta append_window_start,
+ base::TimeDelta append_window_end,
+ base::TimeDelta* timestamp_offset);
// Remove buffers between |start| and |end| for the source buffer
// associated with |id|.

Powered by Google App Engine
This is Rietveld 408576698