media/filters/chunk_demuxer_unittest.cc - Issue 256583006: Fix possible buffer emission during an abort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/chunk_demuxer_unittest.cc

Issue 256583006: Fix possible buffer emission during an abort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/chunk_demuxer_unittest.cc

diff --git a/media/filters/chunk_demuxer_unittest.cc b/media/filters/chunk_demuxer_unittest.cc

index e477eee1d982fb954978dfaedbd5e8127befb66e..2657419c7c6e336c2b88054cc78dcb9bcb81cd20 100644

--- a/media/filters/chunk_demuxer_unittest.cc

+++ b/media/filters/chunk_demuxer_unittest.cc

@@ -2725,7 +2725,7 @@ TEST_P(ChunkDemuxerTest, IsParsingMediaSegmentMidMediaSegment) {

// Confirm we're in the middle of parsing a media segment.

ASSERT_TRUE(demuxer_->IsParsingMediaSegment(kSourceId));

- demuxer_->Abort(kSourceId);

+ demuxer_->Abort(kSourceId, timestamp_offset_map_[kSourceId]);

// After Abort(), parsing should no longer be in the middle of a media

// segment.

ASSERT_FALSE(demuxer_->IsParsingMediaSegment(kSourceId));