Fix possible buffer emission during an abort.

content/renderer/media/websourcebuffer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/websourcebuffer_impl.h"
 
 #include <limits>
 
 #include "base/float_util.h"
 #include "media/filters/chunk_demuxer.h"
@@ skipping 70 matching lines @@
   // Coded frame processing may update the timestamp offset. If the caller
   // provides a non-NULL |timestamp_offset| and frame processing changes the
   // timestamp offset, report the new offset to the caller. Do not update the
   // caller's offset otherwise, to preserve any pre-existing value that may have
   // more than microsecond precision.
   if (timestamp_offset && old_offset != timestamp_offset_)
     *timestamp_offset = timestamp_offset_.InSecondsF();
 }
 
 void WebSourceBufferImpl::abort() {
-  demuxer_->Abort(id_);
+  demuxer_->Abort(id_, timestamp_offset_);

[wolenetz, 2014/04/25 21:00:32]

append_window_{start,end}_ should also be part of processing any buffers the
parser emits as a result of abort() flushing the parser. For example, if an
emitted buffer is outside the append window, then it should not be buffered (and
a discontinuity should be triggered in case subsequent buffers fall within the
append window).
Also, |timestamp_offset_| might be updated by the coded frame processing
algorithm's processing of buffers emitted by the abort(). Pass it by reference
here?

[damienv1, 2014/05/05 22:39:13]

Done. Somehow, I was thinking that the timestamp offset was reset after an abort
(that's why I passed it by value).

 }
 
 void WebSourceBufferImpl::remove(double start, double end) {
   DCHECK_GE(start, 0);
   DCHECK_GE(end, 0);
   demuxer_->Remove(id_, DoubleToTimeDelta(start), DoubleToTimeDelta(end));
 }
 
 bool WebSourceBufferImpl::setTimestampOffset(double offset) {
   if (demuxer_->IsParsingMediaSegment(id_))
@@ skipping 12 matching lines @@
   DCHECK_GE(end, 0);
   append_window_end_ = DoubleToTimeDelta(end);
 }
 
 void WebSourceBufferImpl::removedFromMediaSource() {
   demuxer_->RemoveId(id_);
   demuxer_ = NULL;
 }
 
 }  // namespace content