Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: tools/perf/docs/perf_bot_sheriffing.md

Issue 2565793002: Add logdog and logcat tips to perf sheriffing doc. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Perf Bot Sheriffing 1 # Perf Bot Sheriffing
2 2
3 The perf bot sheriff is responsible for keeping the bots on the chromium.perf 3 The perf bot sheriff is responsible for keeping the bots on the chromium.perf
4 waterfall up and running, and triaging performance test failures and flakes. 4 waterfall up and running, and triaging performance test failures and flakes.
5 5
6 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)** 6 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)**
7 7
8 ## Key Responsibilities 8 ## Key Responsibilities
9 9
10 * [Handle Device and Bot Failures](#Handle-Device-and-Bot-Failures) 10 * [Handle Device and Bot Failures](#Handle-Device-and-Bot-Failures)
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 * The revision range the test occurred on. 183 * The revision range the test occurred on.
184 * A list of all platforms the test fails on. 184 * A list of all platforms the test fails on.
185 2. Disable the failing test if it is failing more than one out of five runs. 185 2. Disable the failing test if it is failing more than one out of five runs.
186 (see below for instructions on telemetry and other types of tests). Make 186 (see below for instructions on telemetry and other types of tests). Make
187 sure your disable cl includes a BUG= line with the bug from step 1 and the 187 sure your disable cl includes a BUG= line with the bug from step 1 and the
188 test owner is cc-ed on the bug. 188 test owner is cc-ed on the bug.
189 3. After the disable CL lands, you can downgrade the priority to Pri-2 and 189 3. After the disable CL lands, you can downgrade the priority to Pri-2 and
190 ensure that the bug title reflects something like "Fix and re-enable 190 ensure that the bug title reflects something like "Fix and re-enable
191 testname". 191 testname".
192 4. Investigate the failure. Some tips for investigating: 192 4. Investigate the failure. Some tips for investigating:
193 * When viewing buildbot step logs, **use the **<font color="blue">[stdout] </font>** link to view logs!**.
194 This will link to logdog logs which do not expire. Do not use or link
195 to the logs found through the <font color="blue">stdio</font> link
196 whenever possible as these logs will expire.
197 * When investigating Android, look for the logcat which is uploaded to
198 Google Storage at the end of the run. logcat will contain much more
199 detailed Android device and crash info than will be found in
200 Telemetry logs.
193 * If it's a non flaky failure, indentify the first failed 201 * If it's a non flaky failure, indentify the first failed
194 build so you can narrow down the range of CLs that causes the failure. 202 build so you can narrow down the range of CLs that causes the failure.
195 You can use the 203 You can use the
196 [diagnose_test_failure](https://code.google.com/p/chromium/codesearch#ch romium/src/tools/perf/diagnose_test_failure) 204 [diagnose_test_failure](https://code.google.com/p/chromium/codesearch#ch romium/src/tools/perf/diagnose_test_failure)
197 script to automatically find the first failed build and the good & bad 205 script to automatically find the first failed build and the good & bad
198 revisions (which can also be used for return code bisect). 206 revisions (which can also be used for return code bisect).
199 * If you suspect a specific CL in the range, you can revert it locally and 207 * If you suspect a specific CL in the range, you can revert it locally and
200 run the test on the 208 run the test on the
201 [perf trybots](https://www.chromium.org/developers/telemetry/performance -try-bots). 209 [perf trybots](https://www.chromium.org/developers/telemetry/performance -try-bots).
202 * You can run a return code bisect to narrow down the culprit CL: 210 * You can run a return code bisect to narrow down the culprit CL:
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 287
280 **[Pri-2 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-2)** 288 **[Pri-2 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3A Performance-Sheriff-BotHealth+label%3APri-2)**
281 are for disabled tests. These should be pinged weekly, and work towards fixing 289 are for disabled tests. These should be pinged weekly, and work towards fixing
282 should be ongoing when the sheriff is not working on a Pri-1 issue. Here is the 290 should be ongoing when the sheriff is not working on a Pri-1 issue. Here is the
283 [list of Pri-2 bugs that have not been pinged in a week](https://bugs.chromium.o rg/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label:Pr i-2%20modified-before:today-7&sort=modified). 291 [list of Pri-2 bugs that have not been pinged in a week](https://bugs.chromium.o rg/p/chromium/issues/list?can=2&q=label:Performance-Sheriff-BotHealth%20label:Pr i-2%20modified-before:today-7&sort=modified).
284 292
285 <!-- Unresolved issues: 293 <!-- Unresolved issues:
286 1. Do perf sheriffs watch the bisect waterfall? 294 1. Do perf sheriffs watch the bisect waterfall?
287 2. Do perf sheriffs watch the internal clank waterfall? 295 2. Do perf sheriffs watch the internal clank waterfall?
288 --> 296 -->
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698