Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9006)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2565783002: Moves ownership of the cc::Display's BeginFrameSource out of Display. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.h ('k') | services/ui/surfaces/display_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index b017329956177fa1c6f306bea8ae2da4815de96d..95bc0d44539f51f451ec1ac7c4d3b5f41c578b6a 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -726,17 +726,15 @@ void CompositorImpl::InitializeDisplay(
cc::SurfaceManager* manager =
ui::ContextProviderFactory::GetInstance()->GetSurfaceManager();
auto* task_runner = base::ThreadTaskRunnerHandle::Get().get();
- std::unique_ptr<ExternalBeginFrameSource> begin_frame_source(
- new ExternalBeginFrameSource(this));
+ begin_frame_source_.reset(new ExternalBeginFrameSource(this));
std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
- begin_frame_source.get(), task_runner,
- display_output_surface->capabilities().max_frames_pending));
+ task_runner, display_output_surface->capabilities().max_frames_pending));
display_.reset(new cc::Display(
HostSharedBitmapManager::current(),
BrowserGpuMemoryBufferManager::current(),
host_->GetSettings().renderer_settings, frame_sink_id_,
- std::move(begin_frame_source), std::move(display_output_surface),
+ begin_frame_source_.get(), std::move(display_output_surface),
std::move(scheduler),
base::MakeUnique<cc::TextureMailboxDeleter>(task_runner)));
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.h ('k') | services/ui/surfaces/display_compositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698