Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: blimp/client/support/compositor/blimp_embedder_compositor.cc

Issue 2565783002: Moves ownership of the cc::Display's BeginFrameSource out of Display. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/support/compositor/blimp_embedder_compositor.cc
diff --git a/blimp/client/support/compositor/blimp_embedder_compositor.cc b/blimp/client/support/compositor/blimp_embedder_compositor.cc
index e15c0c8bf733a2bb06d5819e98961184772958a0..095caeab2317f5977378192030cf4c37326c414c 100644
--- a/blimp/client/support/compositor/blimp_embedder_compositor.cc
+++ b/blimp/client/support/compositor/blimp_embedder_compositor.cc
@@ -209,17 +209,16 @@ void BlimpEmbedderCompositor::HandlePendingCompositorFrameSinkRequest() {
auto display_output_surface =
base::MakeUnique<DisplayOutputSurface>(context_provider_, task_runner);
- std::unique_ptr<cc::SyntheticBeginFrameSource> begin_frame_source(
- new cc::DelayBasedBeginFrameSource(
- base::MakeUnique<cc::DelayBasedTimeSource>(task_runner.get())));
+ begin_frame_source_.reset(new cc::DelayBasedBeginFrameSource(
+ base::MakeUnique<cc::DelayBasedTimeSource>(task_runner.get())));
std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
- begin_frame_source.get(), task_runner.get(),
+ task_runner.get(),
display_output_surface->capabilities().max_frames_pending));
display_ = base::MakeUnique<cc::Display>(
shared_bitmap_manager, gpu_memory_buffer_manager,
host_->GetSettings().renderer_settings, frame_sink_id_,
- std::move(begin_frame_source), std::move(display_output_surface),
+ begin_frame_source_.get(), std::move(display_output_surface),
std::move(scheduler),
base::MakeUnique<cc::TextureMailboxDeleter>(task_runner.get()));
display_->SetVisible(true);
« no previous file with comments | « blimp/client/support/compositor/blimp_embedder_compositor.h ('k') | cc/surfaces/compositor_frame_sink_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698