Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 2565733002: [deoptimizer] Fix Deoptimizer::GetDeoptInfo for last entry. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index 1cf750d46d427f68cfe4504092dd935c18b5120b..6ec71a2ab3e3bdb77717880200f044e0633b277c 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1872,15 +1872,20 @@ TEST(CollectDeoptEvents) {
{
const char* branch[] = {"", "opt_function0", "opt_function0"};
- CHECK_EQ(reason(i::DeoptimizeReason::kNotAHeapNumber),
- GetBranchDeoptReason(env, iprofile, branch, arraysize(branch)));
+ const char* deopt_reason =
+ GetBranchDeoptReason(env, iprofile, branch, arraysize(branch));
+ if (deopt_reason != reason(i::DeoptimizeReason::kNotAHeapNumber) &&
+ deopt_reason != reason(i::DeoptimizeReason::kNotASmi)) {
+ FATAL(deopt_reason);
+ }
}
{
const char* branch[] = {"", "opt_function1", "opt_function1"};
const char* deopt_reason =
GetBranchDeoptReason(env, iprofile, branch, arraysize(branch));
if (deopt_reason != reason(i::DeoptimizeReason::kNaN) &&
- deopt_reason != reason(i::DeoptimizeReason::kLostPrecisionOrNaN)) {
+ deopt_reason != reason(i::DeoptimizeReason::kLostPrecisionOrNaN) &&
+ deopt_reason != reason(i::DeoptimizeReason::kNotASmi)) {
FATAL(deopt_reason);
}
}
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698