Issue 256573003: cc: Remove the capability to give up and leave compositing mode.

Issue 256573003: cc: Remove the capability to give up and leave compositing mode. (Closed)

Created:
6 years, 8 months ago by danakj

Modified:
6 years, 8 months ago

Reviewers:
piman, viettrungluu, enne (OOO), abarth-chromium

CC:
chromium-reviews, danakj+watch_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, jam, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, sievers+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), ojan, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Remove the capability to give up and leave compositing mode. The request to create a fallback OutputSurface should always succeed and there's no way to leave compositing mode. So remove this capability from cc and instead just LOG(FATAL) if the fallback OutputSurface ends up being NULL. The only case where the fallback OutputSurface isn't created is in the ChromeOS browser compositor, and in this case the GpuProcessTransportFactory will LOG(FATAL) before cc even finds out, so this new LOG(FATAL) should never be hit in practice, but documents our expectations. This removes the call to WebWidget::didExitCompositingMode. R=enne BUG=366130, 266666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266089

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -208 lines)			Patch
M	cc/layers/tiled_layer_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	cc/test/fake_layer_tree_host_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/test/layer_tree_test.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/test/layer_tree_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_host.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	cc/trees/layer_tree_host.cc	View	1 chunk	+21 lines, -33 lines	0 comments	Download
M	cc/trees/layer_tree_host_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_unittest_context.cc	View	13 chunks	+11 lines, -94 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_delegated.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/single_thread_proxy.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/trees/single_thread_proxy.cc	View	1 chunk	+7 lines, -20 lines	0 comments	Download
M	cc/trees/thread_proxy.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	cc/trees/thread_proxy.cc	View	3 chunks	+9 lines, -30 lines	0 comments	Download
M	content/browser/renderer_host/compositor_impl_android.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/test/web_layer_tree_view_impl_for_testing.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/examples/compositor_app/compositor_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/examples/compositor_app/compositor_host.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/compositor/compositor.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

danakj

enne: please review cc piman: please review the rest abarth: mojo/ OWNERS

6 years, 8 months ago (2014-04-24 17:54:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/256573003/1

6 years, 8 months ago (2014-04-24 21:47:18 UTC) #7

Message was sent while issue was closed.

Change committed as 266089

Expand Messages | Collapse Messages