Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 25657004: Remove false assertion in ApplyBlockElementCommand::formatSelection() (Closed)

Created:
7 years, 2 months ago by yosin_UTC9
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews
Visibility:
Public.

Description

Remove false assertion in ApplyBlockElementCommand::formatSelection() Note: This patch is preparation of fixing issue 294456. This patch removes false assertion in ApplyBlockElementCommand::formatSelection(), when contents of being indent is modified, e.g. mutation event, |endOfNextParagraph| can hold removed contents. BUG=294456 TEST=n/a R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
7 years, 2 months ago (2013-10-02 08:17:56 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-02 08:31:44 UTC) #2
yosin_UTC9
7 years, 2 months ago (2013-10-02 08:33:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r158701 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698