Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2565593002: [turbofan] regalloc: avoid more redundant intersections (Closed)

Created:
4 years ago by Mircea Trofin
Modified:
4 years ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] regalloc: avoid more redundant intersections Same idea as in the previous change. In addition, explicitly limited to non-aliased registers, because the logic there needs to take account of, well, alias IDs. Left a TODO for that part. BUG=v8:5644 Committed: https://crrev.com/dd10d9b100ecddd0568d224fbc93d1d8b97405f5 Cr-Commit-Position: refs/heads/master@{#41609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/compiler/register-allocator.cc View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Mircea Trofin
ptal - this further lowers the cost of register allocation in pathological cases like sqllite. ...
4 years ago (2016-12-08 22:45:03 UTC) #5
titzer
lgtm
4 years ago (2016-12-08 23:34:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565593002/1
4 years ago (2016-12-08 23:34:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 06:59:10 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 06:59:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd10d9b100ecddd0568d224fbc93d1d8b97405f5
Cr-Commit-Position: refs/heads/master@{#41609}

Powered by Google App Engine
This is Rietveld 408576698