Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2565583002: Revert of Ensure compositor initialized before WindowTreeHost is Shown. (Closed)

Created:
4 years ago by mfomitchev
Modified:
4 years ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure compositor initialized before WindowTreeHost is Shown. (patchset #6 id:100001 of https://codereview.chromium.org/2552003002/ ) Reason for revert: Caused a test to fail Original issue's description: > Ensure compositor initialized before WindowTreeHost is Shown. > > This is merely a sanity check. Technically you could show the host > without initializing it, but chances are you didn't meant to do that (or > you can easily change your code to Init before Show). > > BUG=NONE > > Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac > Cr-Commit-Position: refs/heads/master@{#437285} TBR=sadrul@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/f99e09e2e0234b6d0228606b99374a4deb367060 Cr-Commit-Position: refs/heads/master@{#437353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M ui/aura/mus/window_tree_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 7 chunks +5 lines, -16 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mfomitchev
Created Revert of Ensure compositor initialized before WindowTreeHost is Shown.
4 years ago (2016-12-08 21:33:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565583002/1
4 years ago (2016-12-08 21:34:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 21:37:49 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-08 21:40:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f99e09e2e0234b6d0228606b99374a4deb367060
Cr-Commit-Position: refs/heads/master@{#437353}

Powered by Google App Engine
This is Rietveld 408576698