Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2565563003: Revert of Making WTH::InitCompositor() protected instead of public. (Closed)

Created:
4 years ago by mfomitchev
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Making WTH::InitCompositor() protected instead of public. (patchset #5 id:70001 of https://codereview.chromium.org/2556803002/ ) Reason for revert: Reverting because https://codereview.chromium.org/2552003002/ needs to be reverted Original issue's description: > Making WTH::InitCompositor() protected instead of public. > > BUG=NONE > > Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 > Cr-Commit-Position: refs/heads/master@{#437292} TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/28e64612c75948877633c7577d5440389d833c2c Cr-Commit-Position: refs/heads/master@{#437352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M ash/mus/window_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mash/simple_wm/simple_wm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mfomitchev
Created Revert of Making WTH::InitCompositor() protected instead of public.
4 years ago (2016-12-08 21:32:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565563003/1
4 years ago (2016-12-08 21:33:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 21:36:49 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-08 21:40:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28e64612c75948877633c7577d5440389d833c2c
Cr-Commit-Position: refs/heads/master@{#437352}

Powered by Google App Engine
This is Rietveld 408576698