Instrument SpdySessionPool using MemoryDumpProvider

Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and
SpdySession to track memory usage from active and idle socket.

BUG=669108
Committed: https://crrev.com/36fa039e84bdf32b6d6da8871fb72117cfdcc0d0
Cr-Commit-Position: refs/heads/master@{#437356}

[xunjieli, 2016-12-08 15:57:29]

Description was changed from

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and SpdySession to
track memory usage from active and idle socket.

BUG=669108
==========

to

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and 
SpdySession to track memory usage from active and idle socket.

BUG=669108
==========

[xunjieli, 2016-12-08 16:02:08]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org

[xunjieli, 2016-12-08 16:02:09]

Bence: Could you take a look?
This CL is to instrument idle H2 sessions. This shows that idle H2 sockets are
holding on to 17kB read buffers even when they are idle. David and Matt have a
plan to get rid of the read buffers. This CL is to add instrumentation so we can
get some data. Thanks!

[xunjieli, 2016-12-08 16:02:21]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 16:02:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-12-08 17:02:05]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:02:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-12-08 17:45:36]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-12-08 19:52:32]

LGTM.

https://codereview.chromium.org/2565523002/diff/1/net/socket/client_socket_ha...
File net/socket/client_socket_handle.h (right):

https://codereview.chromium.org/2565523002/diff/1/net/socket/client_socket_ha...
net/socket/client_socket_handle.h:131: // Dumps memory allocation stats.
|parent_dump_absolute_name| is the name
s/parent_dump_absolute_name/parent_absolute_name/

https://codereview.chromium.org/2565523002/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/2565523002/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:574: // Dumps memory allocation stats.
|parent_dump_absolute_name| is the name
Same here.

[xunjieli, 2016-12-08 19:55:17]

Thanks!

https://codereview.chromium.org/2565523002/diff/1/net/socket/client_socket_ha...
File net/socket/client_socket_handle.h (right):

https://codereview.chromium.org/2565523002/diff/1/net/socket/client_socket_ha...
net/socket/client_socket_handle.h:131: // Dumps memory allocation stats.
|parent_dump_absolute_name| is the name
On 2016/12/08 19:52:32, Bence wrote:
> s/parent_dump_absolute_name/parent_absolute_name/

Done.

https://codereview.chromium.org/2565523002/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/2565523002/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:574: // Dumps memory allocation stats.
|parent_dump_absolute_name| is the name
On 2016/12/08 19:52:32, Bence wrote:
> Same here.

Done.

[xunjieli, 2016-12-08 19:55:20]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-12-08 19:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2565523002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-12-08 19:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:42:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481226920540320,
"parent_rev": "472f67d9c6f4821f809aa3579868a27a6f9b5915", "commit_rev":
"d77f4e677b91e4da35fb811cf816e39719a1f477"}

[commit-bot: I haz the power, 2016-12-08 21:43:17]

Description was changed from

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and 
SpdySession to track memory usage from active and idle socket.

BUG=669108
==========

to

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and 
SpdySession to track memory usage from active and idle socket.

BUG=669108
==========

[commit-bot: I haz the power, 2016-12-08 21:43:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-08 21:47:42]

Description was changed from

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and 
SpdySession to track memory usage from active and idle socket.

BUG=669108
==========

to

==========
Instrument SpdySessionPool using MemoryDumpProvider

This CL adds a DumpMemoryStats() method to SpdySessionPool and
SpdySession to track memory usage from active and idle socket.

BUG=669108

Committed: https://crrev.com/36fa039e84bdf32b6d6da8871fb72117cfdcc0d0
Cr-Commit-Position: refs/heads/master@{#437356}
==========

[commit-bot: I haz the power, 2016-12-08 21:47:43]

Patchset 4 (id:??) landed as
https://crrev.com/36fa039e84bdf32b6d6da8871fb72117cfdcc0d0
Cr-Commit-Position: refs/heads/master@{#437356}