Issue 25655004: Print out how many AllocationMementos were found during mark-sweep.

Issue 25655004: Print out how many AllocationMementos were found during mark-sweep. (Closed)

Created:
7 years, 2 months ago by Hannes Payer (out of office)

Modified:
7 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Print out how many AllocationMementos were found during mark-sweep. Moreover use the right memory boundary for AllocationMemento lookup during gc. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17069

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
M	src/heap.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/heap-inl.h	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2	3 chunks	+14 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

LGTM. 1 nit. https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h#newcode529 src/heap-inl.h:529: AllocationSite::CanTrack(object->map()->instance_type()) && See my other comment ...

7 years, 2 months ago (2013-10-02 10:56:45 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h#newcode529 src/heap-inl.h:529: AllocationSite::CanTrack(object->map()->instance_type()) && On 2013/10/02 10:56:45, mvstanton wrote: > See ...

7 years, 2 months ago (2013-10-02 11:02:18 UTC) #3

Hannes Payer (out of office)

7 years, 2 months ago (2013-10-02 11:06:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r17069 (presubmit successful).

Expand Messages | Collapse Messages