Fix GeneratedImage::drawPattern() use of SkPictureBuilder.

Fix GeneratedImage::drawPattern() use of SkPictureBuilder.

SkPictureBuilder records DisplayItems and plays them into
an SkPicture.  GeneratedImage::drawPattern() was misusing
SkPictureBuilder; using it to create a GraphicsContext and
draw to it directly.  It results in the pattern:

1) GraphicsContext::beginRecording()
2) Draw content to GraphicsContext
3) GraphicsContext::beginRecording() again
5) SkPicture picture = GraphicsContext::endRecording()

This is hitting undefined behavior in SkPictureRecorder which
happens to work but is a bug.

This change removes SkPictureBuilder and records directly
to a GraphicsContext.

BUG=672618
Committed: https://crrev.com/45c66caf87f28914324b9851f83216fa58971915
Cr-Commit-Position: refs/heads/master@{#437478}

[vmiura, 2016-12-09 01:39:07]

The CQ bit was checked by vmiura@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 01:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmiura, 2016-12-09 01:40:10]

vmiura@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[vmiura, 2016-12-09 01:40:11]

ptal

[chrishtr, 2016-12-09 02:02:31]

lgtm

https://codereview.chromium.org/2565433003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp (right):

https://codereview.chromium.org/2565433003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp:36: #include
"platform/graphics/paint/SkPictureBuilder.h"
You can remove this include.

[vmiura, 2016-12-09 03:44:28]

The CQ bit was checked by vmiura@chromium.org

[vmiura, 2016-12-09 03:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2565433003/#ps20001
(title: "Remove old include.  Add DCHECK to GC::beginRecording.")

[commit-bot: I haz the power, 2016-12-09 03:44:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmiura, 2016-12-09 03:48:57]

https://codereview.chromium.org/2565433003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp (right):

https://codereview.chromium.org/2565433003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp:36: #include
"platform/graphics/paint/SkPictureBuilder.h"
On 2016/12/09 02:02:31, chrishtr wrote:
> You can remove this include.

Done.

[commit-bot: I haz the power, 2016-12-09 05:36:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481255068815070,
"parent_rev": "7e38ac3d8acb884960d3665a29ff12157d35ce3d", "commit_rev":
"fab6671416a4dbf20d611dad32573b3b5cb4360a"}

[commit-bot: I haz the power, 2016-12-09 05:37:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 05:38:56]

Description was changed from

==========
Fix GeneratedImage::drawPattern() use of SkPictureBuilder.

SkPictureBuilder records DisplayItems and plays them into
an SkPicture.  GeneratedImage::drawPattern() was misusing
SkPictureBuilder; using it to create a GraphicsContext and
draw to it directly.  It results in the pattern:

1) GraphicsContext::beginRecording()
2) Draw content to GraphicsContext
3) GraphicsContext::beginRecording() again
5) SkPicture picture = GraphicsContext::endRecording()

This is hitting undefined behavior in SkPictureRecorder which
happens to work but is a bug.

This change removes SkPictureBuilder and records directly
to a GraphicsContext.

BUG=672618
==========

to

==========
Fix GeneratedImage::drawPattern() use of SkPictureBuilder.

SkPictureBuilder records DisplayItems and plays them into
an SkPicture.  GeneratedImage::drawPattern() was misusing
SkPictureBuilder; using it to create a GraphicsContext and
draw to it directly.  It results in the pattern:

1) GraphicsContext::beginRecording()
2) Draw content to GraphicsContext
3) GraphicsContext::beginRecording() again
5) SkPicture picture = GraphicsContext::endRecording()

This is hitting undefined behavior in SkPictureRecorder which
happens to work but is a bug.

This change removes SkPictureBuilder and records directly
to a GraphicsContext.

BUG=672618

Committed: https://crrev.com/45c66caf87f28914324b9851f83216fa58971915
Cr-Commit-Position: refs/heads/master@{#437478}
==========

[commit-bot: I haz the power, 2016-12-09 05:38:57]

Patchset 2 (id:??) landed as
https://crrev.com/45c66caf87f28914324b9851f83216fa58971915
Cr-Commit-Position: refs/heads/master@{#437478}