Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256543002: DevTools: do not recognize inline sourceURL, require it to end with the crlf. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: do not recognize inline sourceURL, require it to end with the crlf. BUG=366595 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172522

Patch Set 1 #

Patch Set 2 : With tests #

Patch Set 3 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
A LayoutTests/inspector/sources/debugger/resources/script-with-poor-url.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/resources/script-with-url.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-url-comment.html View 1 2 2 chunks +48 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-url-comment-expected.txt View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pfeldman
6 years, 8 months ago (2014-04-24 12:23:48 UTC) #1
vsevik
lgtm a test?
6 years, 8 months ago (2014-04-24 12:33:22 UTC) #2
pfeldman
On 2014/04/24 12:33:22, vsevik wrote: > lgtm > > a test? done.
6 years, 8 months ago (2014-04-24 13:06:39 UTC) #3
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-24 13:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/256543002/20001
6 years, 8 months ago (2014-04-24 13:07:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 13:15:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-24 13:15:53 UTC) #7
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-24 15:01:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/256543002/30001
6 years, 8 months ago (2014-04-24 15:01:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:10:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-24 15:10:47 UTC) #11
pfeldman
6 years, 8 months ago (2014-04-24 17:13:30 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 manually as r172522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698