Issue 2565413002: Fix rti encoding of generic methods

Issue 2565413002: Fix rti encoding of generic methods (Closed)

Created:
4 years ago by Johnni Winther

Modified:
4 years ago

Reviewers:
Vyacheslav Egorov (Google), Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix rti encoding of generic methods R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d4c9dc92e1b026327dc87967cbb82d6a303a41fa

Patch Set 1 #

Patch Set 2 : Add comment. #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -17 lines)			Patch
M	pkg/compiler/lib/src/dart_types.dart	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/runtime_types.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		1 chunk	+15 lines, -12 lines	0 comments	Download
A	tests/language/generic_method_types_test.dart	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

Committed patchset #2 (id:20001) manually as d4c9dc92e1b026327dc87967cbb82d6a303a41fa (presubmit successful).

4 years ago (2016-12-13 09:28:07 UTC) #5

Vyacheslav Egorov (Google)

Hi Johnni, FYI vm-kernel bots are failing the test you added. I am gonna update ...

4 years ago (2016-12-13 23:09:32 UTC) #7

Johnni Winther

4 years ago (2016-12-14 08:05:57 UTC) #8

Message was sent while issue was closed.

On 2016/12/13 23:09:32, Vyacheslav Egorov (Google) wrote:
> Hi Johnni,
> 
> FYI vm-kernel bots are failing the test you added.
> 
> I am gonna update the status

Thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages