Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: content/public/browser/navigation_controller.h

Issue 25654005: Remove GetActiveEntry usage from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment, added TODO, rebased on ToT. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 // entry is navigated to, a request is sent to the server. While that request 205 // entry is navigated to, a request is sent to the server. While that request
206 // has not been responded to, the NavigationEntry is pending. Once data is 206 // has not been responded to, the NavigationEntry is pending. Once data is
207 // received for that entry, that NavigationEntry is committed. 207 // received for that entry, that NavigationEntry is committed.
208 208
209 // A transient entry is an entry that, when the user navigates away, is 209 // A transient entry is an entry that, when the user navigates away, is
210 // removed and discarded rather than being added to the back-forward list. 210 // removed and discarded rather than being added to the back-forward list.
211 // Transient entries are useful for interstitial pages and the like. 211 // Transient entries are useful for interstitial pages and the like.
212 212
213 // Active entry -------------------------------------------------------------- 213 // Active entry --------------------------------------------------------------
214 214
215 // THIS IS DEPRECATED. DO NOT USE. Use GetVisibleEntry instead.
216 //
215 // Returns the active entry, which is the transient entry if any, the pending 217 // Returns the active entry, which is the transient entry if any, the pending
216 // entry if a navigation is in progress or the last committed entry otherwise. 218 // entry if a navigation is in progress or the last committed entry otherwise.
217 // NOTE: This can be NULL!! 219 // NOTE: This can be NULL!!
218 // 220 //
219 // If you are trying to get the current state of the NavigationController, 221 // If you are trying to get the current state of the NavigationController,
220 // this is the method you will typically want to call. If you want to display 222 // this is the method you will typically want to call. If you want to display
221 // the active entry to the user (e.g., in the location bar), use 223 // the active entry to the user (e.g., in the location bar), use
222 // GetVisibleEntry instead. 224 // GetVisibleEntry instead.
223 virtual NavigationEntry* GetActiveEntry() const = 0; 225 virtual NavigationEntry* GetActiveEntry() const = 0;
224 226
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 435
434 private: 436 private:
435 // This interface should only be implemented inside content. 437 // This interface should only be implemented inside content.
436 friend class NavigationControllerImpl; 438 friend class NavigationControllerImpl;
437 NavigationController() {} 439 NavigationController() {}
438 }; 440 };
439 441
440 } // namespace content 442 } // namespace content
441 443
442 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 444 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698