Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2565223002: Add more specific metrics for main thread scrolling reasons (Closed)
Patch Set: Relocate the logic of updating mainThreadScrollingFromStyle Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
index b5775ab80f437659a1792d800a4e512b198bac16..170b738ddf438623c5a82cf40aeff08aa2336b9a 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
@@ -98,6 +98,8 @@ class CORE_EXPORT ScrollingCoordinator final
bool shouldUpdateScrollLayerPositionOnMainThread() const {
return mainThreadScrollingReasons() != 0;
}
+ void adjustMainThreadReasonsFromStyle(uint32_t reason, bool increase);
+ MainThreadScrollingReasons getMainThreadScrollingReasonsFromStyle() const;
std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer(
ScrollbarOrientation,
@@ -184,6 +186,11 @@ class CORE_EXPORT ScrollingCoordinator final
bool m_wasFrameScrollable;
MainThreadScrollingReasons m_lastMainThreadScrollingReasons;
+ // For recording main thread scrolling reasons
+ // due to layout object properties. e.g. opacity, transform.
+ // The size of the vector depends on the number of
+ // main thread scrolling reasons.
+ Vector<int> m_mainThreadScrollingReasonLayoutCounter;
bokan 2016/12/14 13:28:59 ReasonLayoutCounter -> ReasonsCounter
yigu 2016/12/14 21:17:33 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698