third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2565223002: Add more specific metrics for main thread scrolling reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2565223002: Add more specific metrics for main thread scrolling reasons (Closed)

Patch Set: Add unit test && refactoring Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h » ('j') | third_party/WebKit/Source/web/tests/data/two_transparent_scrollable_area.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index fe04c5a66b7f62cd407af5223674f1da69f07753..df13ee13272bf73a7da582b4aa201218287a4d70 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -1174,6 +1174,9 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons()

if (frameView->hasBackgroundAttachmentFixedObjects())

reasons |=

MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;

+ reasons |= frameView->checkMainThreadScrollingReasonDueToLayoutObject();

FrameView::ScrollingReasons scrollingReasons =

frameView->getScrollingReasons();

const bool mayBeScrolledByInput =