Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2565223002: Add more specific metrics for main thread scrolling reasons (Closed)
Patch Set: Refactoring && merging master Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 m_hadVerticalScrollbarBeforeRelayout = val; 469 m_hadVerticalScrollbarBeforeRelayout = val;
470 } 470 }
471 471
472 StickyConstraintsMap& stickyConstraintsMap() { 472 StickyConstraintsMap& stickyConstraintsMap() {
473 return ensureRareData().m_stickyConstraintsMap; 473 return ensureRareData().m_stickyConstraintsMap;
474 } 474 }
475 void invalidateAllStickyConstraints(); 475 void invalidateAllStickyConstraints();
476 void invalidateStickyConstraintsFor(PaintLayer*, 476 void invalidateStickyConstraintsFor(PaintLayer*,
477 bool needsCompositingUpdate = true); 477 bool needsCompositingUpdate = true);
478 478
479 void removeStyleRelatedMainThreadScrollingReasons();
480 void addStyleRelatedMainThreadScrollingReasons(const uint32_t);
481 bool hasMainThreadScrollingReason(uint32_t reason) const {
482 return m_reasons & reason;
483 }
484 void setMainThreadScrollingReason(uint32_t reason) { m_reasons |= reason; }
bokan 2016/12/20 19:35:53 These aren't called from outside the class and onl
yigu 2016/12/20 19:59:31 Done.
485 void resetMainThreadScrollingReason(uint32_t reason) { m_reasons &= ~reason; }
486
479 uint64_t id() const; 487 uint64_t id() const;
480 488
481 DECLARE_VIRTUAL_TRACE(); 489 DECLARE_VIRTUAL_TRACE();
482 490
483 private: 491 private:
484 explicit PaintLayerScrollableArea(PaintLayer&); 492 explicit PaintLayerScrollableArea(PaintLayer&);
485 493
486 bool hasHorizontalOverflow() const; 494 bool hasHorizontalOverflow() const;
487 bool hasVerticalOverflow() const; 495 bool hasVerticalOverflow() const;
488 bool hasScrollableHorizontalOverflow() const; 496 bool hasScrollableHorizontalOverflow() const;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 ScrollingCoordinator* getScrollingCoordinator() const; 532 ScrollingCoordinator* getScrollingCoordinator() const;
525 533
526 PaintLayerScrollableAreaRareData* rareData() { return m_rareData.get(); } 534 PaintLayerScrollableAreaRareData* rareData() { return m_rareData.get(); }
527 535
528 PaintLayerScrollableAreaRareData& ensureRareData() { 536 PaintLayerScrollableAreaRareData& ensureRareData() {
529 if (!m_rareData) 537 if (!m_rareData)
530 m_rareData = WTF::makeUnique<PaintLayerScrollableAreaRareData>(); 538 m_rareData = WTF::makeUnique<PaintLayerScrollableAreaRareData>();
531 return *m_rareData.get(); 539 return *m_rareData.get();
532 } 540 }
533 541
542 bool layerNeedsCompositedScrolling(const LCDTextMode, const PaintLayer*);
534 PaintLayer& m_layer; 543 PaintLayer& m_layer;
535 544
536 PaintLayer* m_nextTopmostScrollChild; 545 PaintLayer* m_nextTopmostScrollChild;
537 PaintLayer* m_topmostScrollChild; 546 PaintLayer* m_topmostScrollChild;
538 547
539 // Keeps track of whether the layer is currently resizing, so events can cause 548 // Keeps track of whether the layer is currently resizing, so events can cause
540 // resizing to start and stop. 549 // resizing to start and stop.
541 unsigned m_inResizeMode : 1; 550 unsigned m_inResizeMode : 1;
542 unsigned m_scrollsOverflow : 1; 551 unsigned m_scrollsOverflow : 1;
543 552
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 // LayoutObject to hold our custom scroll corner. 584 // LayoutObject to hold our custom scroll corner.
576 LayoutScrollbarPart* m_scrollCorner; 585 LayoutScrollbarPart* m_scrollCorner;
577 586
578 // LayoutObject to hold our custom resizer. 587 // LayoutObject to hold our custom resizer.
579 LayoutScrollbarPart* m_resizer; 588 LayoutScrollbarPart* m_resizer;
580 589
581 ScrollAnchor m_scrollAnchor; 590 ScrollAnchor m_scrollAnchor;
582 591
583 std::unique_ptr<PaintLayerScrollableAreaRareData> m_rareData; 592 std::unique_ptr<PaintLayerScrollableAreaRareData> m_rareData;
584 593
594 // MainThreadScrollingReason due to the properties of the LayoutObject
595 uint32_t m_reasons;
596
585 #if ENABLE(ASSERT) 597 #if ENABLE(ASSERT)
586 bool m_hasBeenDisposed; 598 bool m_hasBeenDisposed;
587 #endif 599 #endif
588 }; 600 };
589 601
590 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 602 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
591 ScrollableArea, 603 ScrollableArea,
592 scrollableArea, 604 scrollableArea,
593 scrollableArea->isPaintLayerScrollableArea(), 605 scrollableArea->isPaintLayerScrollableArea(),
594 scrollableArea.isPaintLayerScrollableArea()); 606 scrollableArea.isPaintLayerScrollableArea());
595 607
596 } // namespace blink 608 } // namespace blink
597 609
598 #endif // LayerScrollableArea_h 610 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698