Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/reading_list/ios/reading_list_store_delegate.h

Issue 2565213002: Add destructor to ReadingListStoreDelegate (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/reading_list_store_delegate.h
diff --git a/components/reading_list/ios/reading_list_store_delegate.h b/components/reading_list/ios/reading_list_store_delegate.h
index ff4b14b52d1f7778303dacc8355af4f299053fa0..03448c2d66aad0daeababb8c5fe69aee9540da46 100644
--- a/components/reading_list/ios/reading_list_store_delegate.h
+++ b/components/reading_list/ios/reading_list_store_delegate.h
@@ -7,11 +7,16 @@
#include <map>
+#include "base/macros.h"
+
class ReadingListEntry;
// The delegate to handle callbacks from the ReadingListStore.
class ReadingListStoreDelegate {
public:
+ ReadingListStoreDelegate() {}
+ virtual ~ReadingListStoreDelegate() {}
+
using ReadingListEntries = std::map<GURL, ReadingListEntry>;
// These three mathods handle callbacks from a ReadingListStore.
sdefresne 2016/12/11 19:34:51 nit: can you fix typo here "mathods" should be spe
Olivier 2016/12/11 19:39:27 Done.
virtual void StoreLoaded(std::unique_ptr<ReadingListEntries> entries) = 0;
sdefresne 2016/12/11 19:34:51 nit: this method has no comment (the comment above
Olivier 2016/12/11 19:39:27 Done.
@@ -29,6 +34,8 @@ class ReadingListStoreDelegate {
// Called to remove an entry to the model.
virtual void SyncRemoveEntry(const GURL& url) = 0;
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ReadingListStoreDelegate);
};
#endif // COMPONENTS_READING_LIST_IOS_READING_LIST_STORE_DELEGATE_H_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698