Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2565173008: Fix for resynthesizing invalid @functionName() annotations. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for resynthesizing invalid @functionName() annotations. It should not cause an exception and resolution failure. R=paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/28099 Committed: https://github.com/dart-lang/sdk/commit/871f478c63fa0332cc9630e2351eb060042357e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +12 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-14 17:32:59 UTC) #1
Paul Berry
lgtm
4 years ago (2016-12-14 18:21:29 UTC) #2
scheglov
4 years ago (2016-12-14 18:45:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
871f478c63fa0332cc9630e2351eb060042357e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698