third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js - Issue 2565113002: DevTools: update console viewport scroll when prompt is resized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

Issue 2565113002: DevTools: update console viewport scroll when prompt is resized (Closed)

Patch Set: return to first approach Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

diff --git a/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js b/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

index ee0ec96ec454fb6b1855e98e97729403b6b427f0..1254046e2c9f09bfd386143035661fba0b366db8 100644

--- a/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

+++ b/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

@@ -1022,8 +1022,10 @@ TextEditor.CodeMirrorTextEditor = class extends UI.VBox {

return;

// We do not show "scroll beyond end of file" span for one line documents, so we need to check if "document has one line" changed.

var hasOneLine = this._codeMirror.lineCount() === 1;

- if (hasOneLine !== this._hasOneLine)

+ if (hasOneLine !== this._hasOneLine) {

this._resizeEditor();

+ this.widget().dispatchEventToListeners(UI.TextEditor.Events.EditorResized);

+ }

this._hasOneLine = hasOneLine;

this._decorations.valuesArray().forEach(decoration => this._codeMirror.removeLineWidget(decoration.widget));