third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js - Issue 2565113002: DevTools: update console viewport scroll when prompt is resized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2565113002: DevTools: update console viewport scroll when prompt is resized (Closed)

Patch Set: return to first approach Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

index 6b8f50f9c2939558001c6a6dcd02c3e1324c325b..3b9d269b1c48e29d93bd203210831a29ada79e5f 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

@@ -32,6 +32,9 @@ Console.ConsolePrompt = class extends UI.Widget {

});

this._editor.widget().element.addEventListener('keydown', this._editorKeyDown.bind(this), true);

this._editor.widget().show(this.element);

+ var consoleView = Console.ConsoleView.instance();

dgozman 2016/12/14 17:28:43 This looks bad - ConsolePrompt should not reach in

+ var onEditorResized = consoleView.scheduleViewportRefresh.bind(consoleView);

+ this._editor.widget().addEventListener(UI.TextEditor.Events.EditorResized, onEditorResized);

this.setText(this._initialText);

delete this._initialText;